cannot parse cmake.generator correctly

[nicolgo]

Brief Issue Summary

my previous setting of cmake.generator is "Visual Studio 15 2017 Win64", it work well before, but when I update the extension to v1.19.49 today, it cannot parse the string correctly,

[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE --no-warn-unused-cli -SC:/Users/dell/Documents/repos/fpcserver -Bc:/Users/dell/Documents/repos/fpcserver/build-RelWithDebInfo -G "Visual Studio 15 2017" -A " Win64"

but I change the setting to "cmake.generator": "Visual Studio 15 2017Win64", it can parse correctly.

CMake Tools Diagnostics

{
  "os": "win32",
  "vscodeVersion": "1.85.1",
  "cmtVersion": "1.19.49",
  "configurations": [
    {
      "folder": "c:\\Users\\dell\\Documents\\repos\\fpcserver",
      "cmakeVersion": "3.26.4",
      "configured": false,
      "generator": "Visual Studio 15 2017",
      "usesPresets": false,
      "compilers": {}
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": true
    }
  ]
}

Debug Log

[cmake] -- Configuring incomplete, errors occurred!
[proc] The command: "C:\Program Files\CMake\bin\cmake.EXE" -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE --no-warn-unused-cli -SC:/Users/dell/Documents/repos/fpcserver -Bc:/Users/dell/Documents/repos/fpcserver/build-RelWithDebInfo -G "Visual Studio 15 2017" -A " Win64" exited with code: 1

Additional Information

No response

[gcampbell-msft]

Nicolas Gong (@nicolgo) Is there any repro steps you can provide, or a repro project that would allow for easy reproduction of this issue so that we can investigate?

Can you show me what the command-line looked like on versions before this one? Also, if you have time, diagnosing which pre-release version introduced this could help us greatly. Thanks!

[nicolgo]

Hi Garrett Campbell (@gcampbell-msft), I attached a small project, you just need to change the "cmake.generator": "Visual Studio 15 2017Win64" in .vscode/settings.json to "cmake.generator": "Visual Studio 15 2017 Win64", and ctrl+shift+p run CMake: Delete Cache and Reconfigure, you will find one can success, one will fail.
helloworld.zip

[gcampbell-msft]

Thanks Nicolas Gong (@nicolgo).

I've investigated this and it looks like a recent improvement we've made exposed the fact that we don't currently support the edge case of generators that were supported in CMake versions prior to 3.1. From the docs here: https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2015%202017.html#platform-selection, it looks like you could be using simply "Visual Studio 15 2017", based on your cmake version, and then you could set the cmake.platform version.

We also could fix the interpretation we do here:

vscode-cmake-tools/src/drivers/cmakeDriver.ts

Line 1011 in 96f67f1

platform: gen.platform || vsMatch[2],

, to make sure that we use a -A "x64" rather than -A "Win64"

[gcampbell-msft]

Nicolas Gong (@nicolgo) Could you let me know whether simply using Visual Studio 15 2017 works for you?

[nicolgo]

Garrett Campbell (@gcampbell-msft) yes, setting "cmake.generator": "Visual Studio 15 2017" works well, the platform will be -A "x64" by default. Thank you~

[gcampbell-msft]

Great. I'll close this issue for now, but we do plan to implement a fix that I have in this draft PR #4025, but it will likely stay in pre-release until we do the official 1.20 release in 3 months. Please let us know if you feel strongly about getting this into the official release channel sooner than that.

Thanks!