Skip to content

Fix VSTHRD004 mis-fire on NoThrowAwaitable()#1243

Merged
AArnott merged 1 commit into
microsoft:mainfrom
AArnott:fix1232
Oct 24, 2023
Merged

Fix VSTHRD004 mis-fire on NoThrowAwaitable()#1243
AArnott merged 1 commit into
microsoft:mainfrom
AArnott:fix1232

Conversation

@AArnott

@AArnott AArnott commented Oct 23, 2023

Copy link
Copy Markdown
Member

Fixes #1232

@AArnott AArnott requested a review from sharwell October 23, 2023 22:24
}
}
";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra newline.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty line between the test snippet and the assertion is actually customary in this repo.

@AArnott AArnott merged commit 753885e into microsoft:main Oct 24, 2023
@AArnott AArnott deleted the fix1232 branch October 24, 2023 19:09
@AArnott AArnott added this to the v17.9 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSTHRD004 fires for SwitchToMainThreadAsync().NoThrowAwaitable()

2 participants