Skip to content

VSTHRD103 should flag violations amidst use of ?. expressions#1242

Merged
AArnott merged 2 commits into
microsoft:mainfrom
AArnott:fix1235
Oct 24, 2023
Merged

VSTHRD103 should flag violations amidst use of ?. expressions#1242
AArnott merged 2 commits into
microsoft:mainfrom
AArnott:fix1235

Conversation

@AArnott

@AArnott AArnott commented Oct 23, 2023

Copy link
Copy Markdown
Member

VSTHRD103 should flag violations amidst use of ?. expressions

Fixes #1235

Also workaround roslyn analyzer and xunit version , which only shows up when failures occur.

@AArnott AArnott changed the title Fix1235VSTHRD103 should flag violations amidst use of ?. expressions VSTHRD103 should flag violations amidst use of ?. expressions Oct 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line 62 comment, consider moving this above the if.

@AArnott AArnott merged commit 3e95cb0 into microsoft:main Oct 24, 2023
@AArnott AArnott deleted the fix1235 branch October 24, 2023 19:09
@AArnott AArnott added this to the v17.9 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSTHRD103 does not trigger on ?.Result

2 participants