Skip to content

Prevent sending ETW within a lock#1146

Merged
lifengl merged 2 commits into
mainfrom
dev/lifengl/noEtwInLock
Feb 7, 2023
Merged

Prevent sending ETW within a lock#1146
lifengl merged 2 commits into
mainfrom
dev/lifengl/noEtwInLock

Conversation

@lifengl

@lifengl lifengl commented Jan 16, 2023

Copy link
Copy Markdown
Member

This code amplifies ETW trace costs, and makes them into thread pool issues in some traces which leads to more noises in performance tests.

Lifeng Lu added 2 commits January 16, 2023 12:58
This code amplifies overhead of ETW tracing into thread pool issues, and increases noise in perf tests.
@lifengl lifengl requested a review from AArnott January 17, 2023 02:10
@drewnoakes

Copy link
Copy Markdown
Member

Could this end up with events appearing in incorrect order via ETW, and would that be an issue?

@lifengl

lifengl commented Jan 28, 2023

Copy link
Copy Markdown
Member Author

it looks like the optProf data is out of dated in this repo. Maybe OptProf run stops working in this repo? I will rerun it to see whether it can be resolved. @AArnott

@AArnott

AArnott commented Jan 28, 2023

Copy link
Copy Markdown
Member

@lifengl, this repo had been having optprof run problems recently, but I fixed them recently, and we've had a few insertions in the last week.
I think the failures you're seeing are all related to v16.10, which is still broken. But that shouldn't impact this PR or our main branch.

@lifengl lifengl enabled auto-merge February 7, 2023 20:17
@lifengl

lifengl commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

@lifengl, this repo had been having optprof run problems recently, but I fixed them recently, and we've had a few insertions in the last week. I think the failures you're seeing are all related to v16.10, which is still broken. But that shouldn't impact this PR or our main branch.

it somehow blocks this PR to be merged. Maybe this one is created earlier so builds in 17.6 are not excluded?

@AArnott

AArnott commented Feb 7, 2023

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AArnott

AArnott commented Feb 7, 2023

Copy link
Copy Markdown
Member

@lifengl now it isn't optprof, but loc that is breaking the official build. I have #1156 that I believe will resolve it.

@AArnott

AArnott commented Feb 7, 2023

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants