Repository navigation
Feature request: option\setting to prevent\disallow duplicate methods in targets #547
Description
When adding multiple rpc target classes, if multiple targets contain the same\similar method, the method in first target added is used (as documented). But I miss an option to disallow duplicates, as this is (in my case) always an error. Alternatives:
-Preferably a setting on JsonRpc itself that produce error when AddLocalRpcTarget is called
-A setting on JsonRpc itself that produce error during runtime, when duplicate method is attempted called
-A setting in JsonRpcTargetOptions, that produce error when AddLocalRpcTarget is called
-A setting in JsonRpcTargetOptions, that produce error during runtime, when duplicate method is attempted called
Thanks.
Activity
AArnott commentedon Sep 10, 2020
Thanks for the feedback.
I think this is a reasonable design.
osexpert commentedon Sep 12, 2020
Another thing that could solve the problem for me was if I could create multiple proxies and specify proxy option to alter method name (via delegate), eg. proxy for Service1 would postfix methods with Service1_ etc. Target already has option for method name modification so AddLocalRpcTarget(new Service1(), options) would already expose methods prefixed Service1_
AArnott commentedon Sep 13, 2020
Interesting. @gdalsnes are you aware that
JsonRpcProxyOptionsalso offers you a method name transform delegate? So you can add the service prefix both on the target and proxy sides already.vs-streamjsonrpc/src/StreamJsonRpc/JsonRpcProxyOptions.cs
Line 53 in d945aa8
osexpert commentedon Sep 13, 2020
Ok great, I will try that!
osexpert commentedon Sep 14, 2020
It works but it actually got a lot more complicated with dozens of proxies instead of one super-proxy IServer (IServer : IService1, IService2, etc.) that I use via generic wrapper, the wrapper has a reference to the super-proxy, when recreating super-proxy after recreating JsonRpc (when the stream dies etc.) this just works.
So for me I think the duplicate check is still helpful.
Sorry.
rruizGit commentedon Oct 12, 2020
Interesting conversation. We used the method and event name transforms to solve this problem. But, in our case, every target has a unique identifier, so it was easy to transform the name to :.. Also works because information on every target is published as part of our discovery system, so we are able to hide this complexity from someone using the system.
Merge pull request microsoft#547 from AArnott/aarnott-fix-codecov-pub…