Give our NavigationView's acrylic a fallback color - #9752
Merged
1 commit merged intoApr 9, 2021
Merged
Conversation
It will be a different color than the background, so it will look less weird when it's unfocused. It also fixes the bug where the navigation menu is transparent when acrylic is disabled systemwide. Fixes #9337
ghost
added
Area-SettingsUI
Member
Author
|
This looks like ...
instead of ...
I did not want it to match the titlebar. It is not part of the title bar. It becoming "lighter" matches what happens when acrylic is on (though in Light theme, it becomes grayer ... which is also what happens when acrylic is on) |
Mike Griese (zadjii-msft)
approved these changes
Apr 8, 2021
Dustin L. Howett (DHowett)
added
the
Needs-Second
ghost
requested review from
PankajBhojwani,
Carlos Zamora (carlos-zamora),
Leon Liang (leonMSFT) and
Michael Niksa (miniksa)
April 8, 2021 22:47
Carlos Zamora (carlos-zamora)
approved these changes
Apr 8, 2021
Mike Griese (zadjii-msft)
added
the
AutoMerge
|
Hello Mike Griese (@zadjii-msft)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/duhowett/we're_routed_fall_back
branch
April 9, 2021 10:43
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
4 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be a different color than the background, so it will look less
weird when it's unfocused. It also fixes the bug where the navigation
menu is transparent when acrylic is disabled systemwide.
Fixes #9337