Repository navigation
Create a control unittesting project - #9677
Merged
3 commits merged intoApr 5, 2021
Merged
3 commits merged into
3 commits merged into
Conversation
This comment has been minimized.
This comment has been minimized.
Michael Niksa (miniksa)
suggested changes
Mar 31, 2021
Michael Niksa (miniksa)
left a comment
Michael Niksa (miniksa)
left a comment
Contributor
There was a problem hiding this comment.
Why'd that one guid change? leftover mistake that VS fixed for us?
ghost
added
Needs-Author-Feedback
Carlos Zamora (carlos-zamora)
approved these changes
Mar 31, 2021
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
Michael's handling the guid change. So I'mma just approve this since I don't see anything else worth blocking over.
Mike Griese (zadjii-msft)
added
Area-CodeHealth
Michael Niksa (miniksa)
approved these changes
Apr 5, 2021
Michael Niksa (miniksa)
added
the
AutoMerge
|
Hello Michael Niksa (@miniksa)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/migrie/control-unittests
branch
April 5, 2021 16:08
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the can.
This is a follow up to #9472. Now that we have a control .lib, we can add tests for it.
Unfortunately, the
TermControlitself is a horrible mess. So this new unittest lib is empty for now. I'm working on actual tests as a part of #6842, but this PR is here to keep the diffs smaller.Also, apparently
server.vcxprojhad the wrong GUID in it.