Repository navigation
Change SettingsTab close icon to be smaller - #9324
Merged
1 commit merged intoMar 4, 2021
Merged
1 commit merged into
1 commit merged into
Conversation
ghost
added
Area-SettingsUI
Mike Griese (zadjii-msft)
approved these changes
Mar 2, 2021
Carlos Zamora (carlos-zamora)
added
the
Needs-Second
ghost
requested review from
Dustin L. Howett (DHowett),
PankajBhojwani,
Leon Liang (leonMSFT) and
Michael Niksa (miniksa)
March 2, 2021 18:28
Dustin L. Howett (DHowett)
approved these changes
Mar 4, 2021
Dustin L. Howett (DHowett)
added
the
AutoMerge
|
Hello Dustin L. Howett (@DHowett)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/cazamor/sui/settings-tab-close-icon
branch
March 4, 2021 19:32
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Mar 15, 2021
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Mar 15, 2021
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the wrong close icon for the settings tab. This is a side effect of
TerminalTaboverridingTabBase's implementation.#6800 - Settings UI Epic
Closes #9317