[Carlos Zamora (carlos-zamora)]

ComboBox has a text search function that allows users to type letters, and the ComboBoxItem starting with those letters is shown. In order to enable this functionality, the underlying items must be IStringable. This exposes a ToString() function and fixes all of our issues.

This PR adds the IStringable interface to ColorScheme, Profile, and EnumEntry.

References

#6800 - Settings UI Epic
#8768 - Keyboard Navigation
microsoft/microsoft-ui-xaml#4182 - discussion with WinUI about how to overcome this issue

Validation Steps Performed

Tested...

• Launch > Default Profile
• Color Schemes > Name
• Profile > Appearance > Color scheme
• Profile > Appearance > Font weight

Also tested radio buttons, but those still don't work, unfortunately. Looks like they don't have the same underlying mechanism.

[Carlos Zamora (carlos-zamora)]

Filed #9207 as a follow-up task. Settings model objects should not be IStringable. Instead, the view model should be.

[Deleted user (ghost)]

Hello Dustin L. Howett (@DHowett)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 15 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[Mike Griese (zadjii-msft)]

Okay I hate to block over just a trivial nit. So I won't block but I won't ✔️

[Deleted user (ghost)]

🎉Windows Terminal Preview v1.7.572.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[JeffJefferson]

Is it possible to change the behaviour: "ComboBoxItem starting with those letters is shown" ? I want to type in only a part of the displayed value like the ending letters.

[Mike Griese (zadjii-msft)]

JeffJefferson I don't believe that's possible with a stock ComboBox. We'd need to entirely roll a forked version to support fuzzy matching. Maybe a good request for https://github.com/microsoft/microsoft-ui-xaml? Though, I'm not sure that fuzzy matching like that is common on most combobox UX's in any UI framework. Like, on the web, I'm pretty sure the matching is exclusive to the start of the string.

(happy to be proven wrong)