Skip to content

Teach Find command to populate the search box with selected text - #8521

Merged
1 commit merged into
microsoft:mainfrom
Don-Vito:8307-populate-search-no-config
Dec 10, 2020
Merged

Teach Find command to populate the search box with selected text #8521
1 commit merged into
microsoft:mainfrom
Don-Vito:8307-populate-search-no-config

Conversation

@Don-Vito

@Don-Vito Don-Vito commented Dec 8, 2020 •
edited by DHowett
Loading

Copy link
Copy Markdown
Contributor

If a single line of text is selected, use it to populate the search box.

Closes #8307

@ghost ghost added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Dec 8, 2020
@Don-Vito Don-Vito mentioned this pull request Dec 8, 2020
Closed
4 of 6 tasks
carlos-zamora
Carlos Zamora (carlos-zamora) approved these changes Dec 8, 2020
View reviewed changes

@carlos-zamora Carlos Zamora (carlos-zamora) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want this feature in haha

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 9, 2020
zadjii-msft
Mike Griese (zadjii-msft) approved these changes Dec 9, 2020
View reviewed changes

@zadjii-msft Mike Griese (zadjii-msft) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread src/cascadia/TerminalControl/SearchBoxControl.cpp Resolved
@Don-Vito

Don-Vito commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Mike Griese (@zadjii-msft) - can you please kick the CI?

@zadjii-msft

Mike Griese (zadjii-msft) commented Dec 9, 2020

Copy link
Copy Markdown
Member

Yea, I was just making sure to update #8495 first. Wanted to look at the log if there was anything revealing in it. I learned nothing.

@Don-Vito

Don-Vito commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Yea, I was just making sure to update #8495 first. Wanted to look at the log if there was anything revealing in it. I learned nothing.

Mike Griese (@zadjii-msft) - do you know to answer the question that I asked there? What is this sleep in the initialization?

@zadjii-msft

Mike Griese (zadjii-msft) commented Dec 9, 2020

Copy link
Copy Markdown
Member

Oh jeez, didn't see the reply. I'll follow up on that thread.

@Don-Vito Don-Vito changed the title (Alternative) Teach Find command to populate the search box with selected text Teach Find command to populate the search box with selected text Dec 9, 2020
@Don-Vito

Don-Vito commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Mike Griese (@zadjii-msft) - we have two approves 😛

@DHowett Dustin L. Howett (DHowett) added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 10, 2020
@ghost

Deleted user (ghost) commented Dec 10, 2020

Copy link
Copy Markdown

Hello Dustin L. Howett (@DHowett)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
ghost merged commit c2e84d1 into microsoft:main Dec 10, 2020
@zadjii-msft Mike Griese (zadjii-msft) mentioned this pull request Jan 3, 2021
Closed
@ghost

Deleted user (ghost) commented Jan 28, 2021

Copy link
Copy Markdown

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
MPela (mpela81) pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@Don-Vito @mpela81
Teach Find command to populate the search box with selected text (mic…
7a37ded 
…rosoft#8521)

If a single line of text is selected, use it to populate the search box.

Closes microsoft#8307
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett Dustin L. Howett (DHowett) DHowett approved these changes
@zadjii-msft Mike Griese (zadjii-msft) zadjii-msft approved these changes
+1 more reviewer
@carlos-zamora Carlos Zamora (carlos-zamora) carlos-zamora approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Selected text should populate search box

4 participants

@Don-Vito @zadjii-msft @DHowett @carlos-zamora