[Mike Griese (zadjii-msft)]

Technically, "wether" is a word but I'd be shocked if there's a scenario for us to use it properly in this repo, so I'm pulling it from the dictionary.

Also, in #5200, we added "VTE", which is totally a valid acronym, to the codebase, but not the whitelist. I'm not sure why the bot let me merge it anyways, but I'm fixing it now.

[Dustin L. Howett (MSFT) (DHowett-MSFT)]

Hold up, I’m not sure we should be changing the dictionary itself. I think it’s supposed to be representative of English. /cc Josh Soref (@jsoref) to keep me honest

[Josh Soref (jsoref)]

In general, you shouldn't be adding to dictionary.txt, you can add custom words to any .txt file in https://github.com/microsoft/terminal/tree/master/.github/actions/spell-check/dictionary

As for removing items, if you want to use a subset of the dictionary because it's too likely that people will use a word that, while technically an English word, is not actually the one people should be using, then, yes, removing it from dictionary.txt would be reasonable.

[Josh Soref (jsoref)]

As for why the check didn't block things, that's a bit of a mess:

j4james/terminal#clamp-vt-parameters got a fail from the bot when j4james@d2690a0 was pushed to James Holderness (@j4james) 's repository which triggered d2690a0/comment which is j4james@d2690a0#commitcomment-38185159 which GitHub also renders as #5200 (comment) .

I've fixed the schedule code so that there's a way to ensure comments exist (unfortunately, that check wouldn't appear as an ❌ against the PR, because it runs in response to a different event).

I'm planning to write code so that the bot will "resolve" older comments when it runs again. -- I've started thinking about this code.

I could probably have it add/remove a "review" thing for "changes requested". -- I haven't looked into this yet.

I don't think I'll be able to implement the unwritten bits before mid-April, but if you update to the current release (0.0.13-alpha), you can at least use advice to remind reviewers to make sure that the comments are addressed. I could make a PR to update this repo today. advice is now merged which will hopefully help a little.

[Deleted user (ghost)]

Hello Mike Griese (@zadjii-msft)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 59 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[James Holderness (j4james)]

FYI, I definitely got a notification of the VTE spelling issue. I just didn't know how to go about whitelisting it, and I had intended to follow up on that, but the PR got merged a bit faster than I had expected.

[Dustin L. Howett (MSFT) (DHowett-MSFT)]

Sorry about that 😄

[Mike Griese (zadjii-msft)]

James Holderness (@j4james) no worries, I thought it had been resolved since the PR wasn't blocked, but it's nbd. We've merged much worse problems into master before 😅