[Deleted user (ghost)]

Summary of the Pull Request

Since we are now doing spellchecking, I thought I'd help out.

References

#4799

PR Checklist

• CLA signed. If not, go over here and sign the CLA
• Tests added/passed

Detailed Description of the Pull Request / Additional comments

Spell Checks

Validation Steps Performed

[Mike Griese (zadjii-msft)]

Should we remove "colortable", "PowerShell" from the whitelist/dictionary to make sure that we get all these cases?

[Deleted user (ghost)]

Yes let us remove those

[Deleted user (ghost)]

except some commands use the lowercase variant, and those commands are documented here, so... that is where things get tricky

[Josh Soref (jsoref)]

pi1024e: You can add entries into patterns to specifically accept a phrase (technically text matching patterns you add are removed before it parses things looking for unrecognized items).

An example pattern:

\b(?:)powershell -noprofile\b

---

I'm going to have to change how the output works, in theory you'd want to be told to remove entries from the whitelist, but right now you'll only see that if you add one misspelling or if you run w/ debug... For the time being, I'd suggest making an extra local branch in your repository on top of this branch and having it have a single misspelling -- you'd never create a PR from this branch nor merge it. You can then use the output to remove whitelist entries from this branch.

I was trying to avoid having the bot be too chatty, but I think people will probably be ok (or at least you would) w/ being told how to remove things from the whitelist.

[Josh Soref (jsoref)]

Right now the spell checker is actively ignoring .yml files. You could work on removing that exclusion:

terminal/.github/actions/spell-check/excludes.txt

Line 52 in 31efd69

\.yml$

I think the reason I excluded .yml files is that they often have shas in them, but a glance at this repository indicates that they don't, so one could (should?) remove that exclusion.

[Michael Niksa (miniksa)]

Suggested change

	PowerShell Core generator would return `Microsoft.Terminal.PowershellCore`.
	PowerShell Core generator would return `Microsoft.Terminal.PowerShellCore`.

[Josh Soref (jsoref)]

You probably don't want that extra blank line. GitHub changed the default behavior of suggestion such that on average suggestions include one -- fairly annoying.

[Michael Niksa (miniksa)]

I don't believe this needs to be capitalized as the object name. I think the generic "color scheme" terminology was sufficient.

[Deleted user (ghost)]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.