Repository navigation
Simplify non-client hit testing in NCIslandWindow to fix doubleclick - #3024
Merged
Merged
Conversation
It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as our NCHITTEST tells win32 that all of the titlebar is actually non-client area. This brings the code in line with NonNonClientIslandWindow. Fixes #2513
Dustin L. Howett (MSFT) (DHowett-MSFT)
requested a review
from Mike Griese (zadjii-msft)
October 1, 2019 23:46
Member
Mike Griese (zadjii-msft)
approved these changes
Oct 2, 2019
Mike Griese (zadjii-msft)
left a comment
Mike Griese (zadjii-msft)
left a comment
Member
There was a problem hiding this comment.
seems good to me..., but definitely worried about that other issue regressing. Considering you added the _DragRegionClickedHandlers call w/in the WM_NC*BUTTON* handlers, this looks like it'll work though.
Mike Griese (zadjii-msft)
added
Area-UserInterface
Contributor
Author
|
Nah, I tested :) |
Dustin L. Howett (MSFT) (DHowett-MSFT)
added
the
Needs-Second
ghost
requested review from
Carlos Zamora (carlos-zamora) and
Michael Niksa (miniksa)
October 2, 2019 16:50
Carlos Zamora (carlos-zamora)
approved these changes
Oct 2, 2019
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
I love it when we mostly delete code and get more functionality haha
Dustin L. Howett (MSFT) (DHowett-MSFT)
pushed a commit
that referenced
this pull request
Oct 3, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.
Fixes #2513
Validation Steps Performed
Went wild with the clicking and dragging.