Repository navigation
docs: update AddASetting guide - #20552
Draft
Darius (DariusHQ) wants to merge 2 commits into
Draft
Darius (DariusHQ) wants to merge 2 commits into
Darius (DariusHQ) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
Leonard Hecker (lhecker)
left a comment
Leonard Hecker (lhecker)
left a comment
Member
There was a problem hiding this comment.
I did not cross-read against the old version, but the new version is overall good.
Author
|
I’ve pushed a commit addressing all four comments. |
Author
|
Leonard Hecker (@lhecker) |
Darius (DariusHQ)
marked this pull request as draft
October 9, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
doc/cascadia/AddASetting.mdto match the current Terminal Settings Model implementation.The guide previously described adding profile and global settings using older patterns, including manual setting declarations in
Profile.h, manual copy/JSON handling inProfile.cpp, and standaloneWINRT_PROPERTYdeclarations inTerminalSettings.hThis update documents the current settings-list and IDL-based architecture, including:
MTSM_PROFILE_SETTINGSMTSM_GLOBAL_ONLY_SETTINGSMTSM_WINDOW_SETTINGSINHERITABLE_SETTINGINHERITABLE_PROFILE_SETTINGIControlSettings/ICoreSettingsControlProperties.handTerminalSettingspackagingProfileViewModelprojection patternsFixes #20550