Skip to content

Bugfix: selection on wide glyph in scrollback buffer #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Carlos Zamora (carlos-zamora) merged 1 commit into from
Jul 10, 2019
Merged

Bugfix: selection on wide glyph in scrollback buffer #1879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cascadia/TerminalCore/TerminalSelection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const SHORT Terminal::_ExpandWideGlyphSelectionLeft(const SHORT xPos, const SHOR
{
// move off by highlighting the lead half too.
// alters position.X
_mutableViewport.DecrementInBounds(position);
_buffer->GetSize().DecrementInBounds(position);
}
return position.X;
}
Expand All @@ -116,7 +116,7 @@ const SHORT Terminal::_ExpandWideGlyphSelectionRight(const SHORT xPos, const SHO
{
// move off by highlighting the trailing half too.
// alters position.X
_mutableViewport.IncrementInBounds(position);
_buffer->GetSize().IncrementInBounds(position);
}
return position.X;
}
Expand Down