[Éléa Dufresne (eleadufresne)]

Summary of the Pull Request

Allow users to preview color schemes by hovering over them with the mouse pointer in the Command Palette.

References and Relevant Issues

• This PR handles issue Request: "Select color scheme..." mouse-hover should provide color-scheme preview #18238.
• This extends the previously closed issue Allow commands to be previewed in the command palette #6689, which allowed the UP and DOWN arrows to trigger a preview of color schemes in the Command Palette.

Detailed Description of the Pull Request / Additional comments

This works by attaching event handlers for PointerEntered and PointerExited to ListViewItem containers. When the mouse pointer moves into the item's bounding area, the PreviewAction handler is triggered to showcase the hovered color scheme. Conversely, when the mouse pointer leaves the item's area, the PreviewAction is executed on the selected item (generally from the UP and DOWN arrows).

Decisions I made, but I'm uncertain about:

• I coded my solution so that PreviewAction is called on the submenu items, as this is where the color schemes are located. I felt invoking the function for each element was unnecessary, but this approach may make it less flexible for future modifications.
• I'm attaching pointer event handlers when the data associated with the ListViewItem changes, but there might be a better approach.

Important note:

• This also provides previews for the other features that the ActionPreviewHandler handles, such as the background opacity of the terminal.

Validation Steps Performed

• Hover a color scheme, and it becomes the active one.
• Pressing ESC at any point to dismiss the command palette, and the scheme returns to the previous one.
• I did not add any additional test, though all existing ColorScheme tests passed.

PR Checklist

• Closes Request: "Select color scheme..." mouse-hover should provide color-scheme preview #18238
• Tests added/passed
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated (if necessary)

[Éléa Dufresne (eleadufresne)]

@microsoft-github-policy-service agree

[Carlos Zamora (carlos-zamora)]

Looks and feels great! Just the one comment before approving. Thanks for doing this!

[Carlos Zamora (carlos-zamora)]

(whoops, clicked the wrong button...)

[Éléa Dufresne (eleadufresne)]

Dustin L. Howett (@DHowett) can you please take a look when you have the chance? Thanks!

[Dustin L. Howett (DHowett)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Dustin L. Howett (DHowett)]

Éléa Dufresne (@eleadufresne) so sorry for the delay! I've been out sick this week, but I'm putting it at the top of my list

[Dustin L. Howett (DHowett)]

ah, you may need to run the code formatter :)

i am dismayed that we are no longer allowed to run these things without team approval - it slows down the whole PR process.

[Éléa Dufresne (eleadufresne)]

Dustin L. Howett (@DHowett) Thanks for taking the time to look at it—especially while you’re not feeling great—and apologies for missing this in my last commit. I ran the formatter, so fingers crossed it passes all the checks this time!

By the way, can I run the pipeline myself now, or should it always be handled by someone from the team?

[Dustin L. Howett (DHowett)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Dustin L. Howett (DHowett)]

unfortunately, it still needs a team member to approve each iteration

[Éléa Dufresne (eleadufresne)]

Ah gotchu, thanks for the info!

[Éléa Dufresne (eleadufresne)]

Dustin L. Howett (@DHowett), looks like all checks have passed 😄 Thanks again for your help! Let me know if you need anything else before merging.

[Leonard Hecker (lhecker)]

One tiny nit, otherwise LGTM!

[Dustin L. Howett (DHowett)]

This looks great! Thanks so much for doing it, and for being patient with us while we were a bit under-staffed. I can't wait to ship this!

[Dustin L. Howett (DHowett)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Dustin L. Howett (DHowett)]

• I'm attaching pointer event handlers when the data associated with the ListViewItem changes, but there might be a better approach.

Honestly, probably not. This is fine with me - so I removed it from the final commit message!

[Éléa Dufresne (eleadufresne)]

Dustin L. Howett (@DHowett) No worries at all! It's been a great learning experience, and I appreciate the guidance. Always happy to help; I'm super excited to see this get merged 😄