Repository navigation
Clean up til::point/size/rect member usage - #14458
Merged
4 commits merged intoDec 1, 2022
Merged
4 commits merged into
4 commits merged into
Conversation
Leonard Hecker (lhecker)
added
the
Area-CodeHealth
Carlos Zamora (carlos-zamora)
approved these changes
Nov 29, 2022
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Comment on lines
-602
to
+609
| const auto requestedBufferSize = data.dwSize; | ||
| if (requestedBufferSize.X != coordScreenBufferSize.X || | ||
| requestedBufferSize.Y != coordScreenBufferSize.Y) | ||
| const auto requestedBufferSize = til::wrap_coord_size(data.dwSize); | ||
| if (requestedBufferSize != coordScreenBufferSize) | ||
| { | ||
| auto& commandLine = CommandLine::Instance(); | ||
|
|
||
| commandLine.Hide(FALSE); | ||
|
|
||
| LOG_IF_FAILED(context.ResizeScreenBuffer(til::wrap_coord_size(data.dwSize), TRUE)); | ||
| LOG_IF_FAILED(context.ResizeScreenBuffer(requestedBufferSize, TRUE)); |
There was a problem hiding this comment.
Note to other reviewers: aside from removing the union in til::point/rect/size, this is the only other change I found that isn't just renaming.
Mike Griese (zadjii-msft)
approved these changes
Nov 30, 2022
Leonard Hecker (lhecker)
added
the
AutoMerge
|
Hello Leonard Hecker (@lhecker)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/lhecker/4015-followup
branch
December 1, 2022 00:40
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #13025 to make the members of
til::point/size/rectuniform and consistent without the use of
unions. The only file that hasany changes is
src/host/getset.cppwhere an if condition was simplified.Validation Steps Performed