Repository navigation
Fix duplication issue for unfocused tabs - #13964
Merged
Merged
Conversation
ghost
added
Area-UserInterface
Carlos Zamora (carlos-zamora)
approved these changes
Sep 27, 2022
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
Nice and easy to read! Thanks!
Leonard Hecker (lhecker)
approved these changes
Oct 10, 2022
Leonard Hecker (lhecker)
added
the
AutoMerge
|
Hello Leonard Hecker (@lhecker)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Dustin L. Howett (DHowett)
approved these changes
Oct 11, 2022
Dustin L. Howett (DHowett)
left a comment
Dustin L. Howett (DHowett)
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this!
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Oct 12, 2022
Instead of using the currently focused tab when an unfocused tab is duplicated, the `_MakePane(...)` function now uses an optional source tab argument that points to the correct tab being duplicated. ## Validation Steps Performed Manually tested on multiple tabs with different profiles. Performed steps: * Construct at least two tabs with different profiles. * Select `Duplicate Tab` option from the dropdown menu of the unfocused tab. * Verify that the new tab has the same profile as the tab it was duplicated from. Closes #13942 (cherry picked from commit 8f08bb0) Service-Card-Id: 86159036 Service-Version: 1.15
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Oct 13, 2022
Instead of using the currently focused tab when an unfocused tab is duplicated, the `_MakePane(...)` function now uses an optional source tab argument that points to the correct tab being duplicated. ## Validation Steps Performed Manually tested on multiple tabs with different profiles. Performed steps: * Construct at least two tabs with different profiles. * Select `Duplicate Tab` option from the dropdown menu of the unfocused tab. * Verify that the new tab has the same profile as the tab it was duplicated from. Closes #13942 (cherry picked from commit 8f08bb0) Service-Card-Id: 86159037 Service-Version: 1.16
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the currently focused tab when an unfocused tab is duplicated, the
_MakePane(...)function now uses an optional source tab argument that points to the correct tab being duplicated.Validation Steps Performed
Manually tested on multiple tabs with different profiles. Performed steps:
Duplicate Taboption from the dropdown menu of the unfocused tab.Closes #13942