[a11y] Announce new tab/pane upon creation by carlos-zamora · Pull Request #13575 · microsoft/terminal

Carlos Zamora (carlos-zamora) · 2022-07-22T21:52:12Z

Summary of the Pull Request

Makes the automation peer for the TerminalPage announce that a new tab/pane was created successfully. In order to do this, we need to store the automation peer for TerminalPage. Then we have easy access to dispatch notifications from it.

Closes #12038

Validation Steps Performed

Open a new tab/pane with Narrator active.

Carlos Zamora (carlos-zamora) · 2022-07-22T21:54:42Z

I could add a similar notification for when the settings tab is opened. I wasn't sure if that was desired though?
I originally tried having this be a part of TerminalTab and Pane, but for some reason the TabViewItem's automation peer would be ignored when it dispatched a notification event.

Carlos Zamora (carlos-zamora) · 2022-07-22T21:57:44Z

oops, doesn't work for duplicate tab. Should be easy to fix. I should check duplicate pane too.

Carlos Zamora (carlos-zamora) · 2022-07-26T21:27:15Z

@msftbot merge this in 10 minutes

Dustin L. Howett (DHowett) · 2022-07-26T21:30:36Z

+    <value>A new tab for the "{}" profile was created successfully</value>
+    <comment>{} will be replaced with the name of the profile (i.e. PowerShell, Command Prompt, etc.). The name may span multiple words. This announcement is read by a screen reader.</comment>
+  </data>
+  <data name="SplitPaneAnnouncement" xml:space="preserve">
+    <value>A new pane for the "{}" profile was created successfully</value>


the wording here throws me a bit (feels clunky).. gut check how it sounds?

A11y team requested: "profile name created successfully"

We've diverged a bit since then haha. I find value in explicitly saying "pane" or "tab". I also think saying "profile" is important because some profile names could be weird. That said, what if we change it to...
"{}" pane/tab created successfully

It's more succinct? But there's still some doubts when it comes to localization. Thoughts?

Mike Griese (zadjii-msft) · 2022-07-29T11:47:08Z

        {
+            page->_processingCommandlineArgs = true;
+            auto finishProcessing = wil::scope_exit([&page]() {
+                page->_processingCommandlineArgs = false;


.... Can't you just use _startupState <= StartupState::Initialized instead of introducing a new member?

No because we're trying to suppress notifications when processing commandline args regardless of initialization step. So your proposal works for wt.exe args from Run, but not from commandline mode in the command palette.

Hmm, i am of two minds. I don't know if I would be surprised if they were suppressed if I just typed in the command that made it happen.

Bill Dengler (codeofdusk) · 2022-08-16T01:09:58Z

NVDA will always filter out notifications from terminal (see nvaccess/nvda#13261). Are these being sent by the TermCtrl provider?

Carlos Zamora (carlos-zamora) · 2022-08-16T19:01:28Z

NVDA will always filter out notifications from terminal (see nvaccess/nvda#13261). Are these being sent by the TermCtrl provider?

These aren't sent by TermCtrl provider. They're sent by a provider for the whole window, which manages the tabs and UI outside/above the terminal area itself.

Tested this with NVDA and NVDA does read out these notifications, probably for the reason above.

Dustin L. Howett (DHowett) · 2022-08-25T18:59:46Z

        {
+            page->_processingCommandlineArgs = true;
+            auto finishProcessing = wil::scope_exit([&page]() {
+                page->_processingCommandlineArgs = false;


Hmm, i am of two minds. I don't know if I would be surprised if they were suppressed if I just typed in the command that made it happen.

…15771) Uses the `RaiseNotificationEvent()` API from UIA automation peers to announce successful `MovePane` and `MoveTab` actions. The announcements are localized in the resw file. Closes #15159 Based on #13575

…15771) Uses the `RaiseNotificationEvent()` API from UIA automation peers to announce successful `MovePane` and `MoveTab` actions. The announcements are localized in the resw file. Closes #15159 Based on #13575 (cherry picked from commit 2fb4a7f) Service-Card-Id: 90438494 Service-Version: 1.18

Dustin L. Howett (DHowett) · 2026-07-31T23:19:15Z

Carlos Zamora (@carlos-zamora) Alright, what should I do about this, Carlos?

ghost added Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 22, 2022

This comment has been minimized.

Sign in to view

Leonard Hecker (lhecker) reviewed Jul 22, 2022

View reviewed changes

Comment thread src/cascadia/TerminalApp/Resources/en-US/Resources.resw Resolved

This comment has been minimized.

Sign in to view

Carlos Zamora added 2 commits July 25, 2022 10:31

[a11y] Announce new tab/pane upon creation

2cb1ff7

fix announcement for duplicate tab/pane

0473430

Carlos Zamora (carlos-zamora) force-pushed the dev/cazamor/a11y-sev3/new-profile-announcement branch from 38ac9c5 to 0473430 Compare July 25, 2022 17:31

Leonard Hecker (lhecker) previously approved these changes Jul 25, 2022

View reviewed changes

Carlos Zamora (carlos-zamora) added the Needs-Second It's a PR that needs another sign-off label Jul 25, 2022

ghost requested review from Dustin L. Howett (DHowett), PankajBhojwani and Mike Griese (zadjii-msft) July 25, 2022 19:17

Mike Griese (zadjii-msft) previously approved these changes Jul 26, 2022

View reviewed changes

ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2022

This comment was marked as outdated.

Sign in to view

Dustin L. Howett (DHowett) reviewed Jul 26, 2022

View reviewed changes

Comment thread src/cascadia/TerminalApp/TerminalPage.cpp Resolved

Dustin L. Howett (DHowett) requested changes Jul 26, 2022

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 26, 2022

Dustin L. Howett (DHowett) removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2022

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 27, 2022

Carlos Zamora (carlos-zamora) removed the Needs-Second It's a PR that needs another sign-off label Jul 27, 2022

don't notify on commandline args; don't cache autoPeer

fd19751

Carlos Zamora (carlos-zamora) assigned Dustin L. Howett (DHowett) Jul 28, 2022

Mike Griese (zadjii-msft) reviewed Jul 29, 2022

View reviewed changes

Mike Griese (zadjii-msft) added this to the Terminal v1.17 milestone Aug 1, 2022

Carlos Zamora (carlos-zamora) requested a review from Dustin L. Howett (DHowett) August 16, 2022 21:09

Dustin L. Howett (DHowett) requested changes Aug 25, 2022

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 25, 2022

Carlos Zamora and others added 2 commits August 25, 2022 16:48

don't use GetProfileForArgs!

6112345

Migrate spelling-0.0.21 changes from main

c189754

Carlos Zamora (carlos-zamora) requested a review from Dustin L. Howett (DHowett) August 25, 2022 23:48

Mike Griese (zadjii-msft) removed this from the Terminal v1.17 milestone Jul 5, 2023

Carlos Zamora (carlos-zamora) mentioned this pull request Jul 27, 2023

Make screen reader announce successful MovePane and MoveTab actions #15771

Merged

Carlos Zamora (carlos-zamora) dismissed stale reviews from Mike Griese (zadjii-msft) and Leonard Hecker (lhecker) via c189754 April 1, 2025 23:06

Carlos Zamora (carlos-zamora) assigned Carlos Zamora (carlos-zamora) and unassigned Dustin L. Howett (DHowett) Aug 7, 2026

Dustin L. Howett (DHowett) closed this Sep 3, 2026

Conversation

Carlos Zamora (carlos-zamora) commented Jul 22, 2022

Summary of the Pull Request

Validation Steps Performed

Uh oh!

This comment has been minimized.

Carlos Zamora (carlos-zamora) commented Jul 22, 2022

Uh oh!

Carlos Zamora (carlos-zamora) commented Jul 22, 2022

Uh oh!

Uh oh!

This comment has been minimized.

Carlos Zamora (carlos-zamora) commented Jul 26, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Dustin L. Howett (DHowett) Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

Carlos Zamora (carlos-zamora) Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

Mike Griese (zadjii-msft) Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

Carlos Zamora (carlos-zamora) Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

Dustin L. Howett (DHowett) Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

Bill Dengler (codeofdusk) commented Aug 16, 2022

Uh oh!

Carlos Zamora (carlos-zamora) commented Aug 16, 2022

Uh oh!

Uh oh!

Uh oh!

Dustin L. Howett (DHowett) Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dustin L. Howett (DHowett) commented Jul 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants