[Carlos Zamora (carlos-zamora)]

Adds the selectAll action which can be used to select all text in the buffer (regardless of whether a selection is present).

References

#3663 - Mark Mode
#4993 - [Scenario] Keyboard selection

PR Checklist

• Closes Ability to select/copy all the text in the session #1469
• Tests added/passed

Detailed Description of the Pull Request / Additional comments

I've made it such that selecting the "entire buffer" really just selects up to the mutable viewport. This seems like a nice QOL improvement since there's generally nothing past that.

When the user selects all, the viewport does not move. This is consistent with CMD behavior and is intended to allow the user to not lose context when selecting everything.

A minor change had to be made to the DxRenderer because this uncovered an underflow issue. Basically, the selection rects were handed to the DxEngine relative to the viewport (which means that some had a negative y-value). At some point, those rects were stored into size_ts, resulting in an underflow issue. This caused the renderer to behave strangely when rendering the selection. Generally, these kinds of issues weren't really noticed because selection would always modify a portion of the viewport.

Funny enough, in a way, this satisfies the "mark mode" scenario because the user now has a way to initiate a selection using only the keyboard. Though this isn't ideal, just a fun thing to point out (that's why I'm not closing the mark mode issue).

Validation Steps Performed

• Verified using DxEngine and AtlasEngine
• select all --> keyboard selection --> start moving the top-left endpoint (and scroll to there)
• select all --> do not scroll automatically

[Dustin L. Howett (DHowett)]

Clever, with the existing selection being a requirement for selecting all. It might be hard for somebody to discover this, unfortunately.

I somewhat wonder if we should just make the default Ctrl+Shift+A, always select all even if there is no selection, and then enable Ctrl+A in Mark Mode

[Mike Griese (zadjii)]

I somewhat wonder if we should just make the default Ctrl+Shift+A, always select all even if there is no selection, and then enable Ctrl+A in Mark Mode

Ack. Especially since there's no way to start a selection with the keyboard ATM

[Dustin L. Howett (DHowett)]

As discussed!

[Carlos Zamora (carlos-zamora)]

Ctrl+Shift+A, always select all even if there is no selection

I'm ok with this, but if that's the case, we should make it a configurable keybinding.

My main reasoning for that is that I really want to separate mark mode stuff and keybindings. For now, I don't want mark mode to be configurable. We'd be introducing a ton of keybindings that are conditional on a selection being present, and that's spooky. If selectAll can be an action that ignores if a selection is present, might as well make it configurable.

and then enable Ctrl+A in Mark Mode

works for me, I'll move this logic over to my mark mode branch then.

[Carlos Zamora (carlos-zamora)]

FYI Most of the new changes were just plumbing the action through, so I'm explicitly not re-requestion a review from Leonard Hecker (@lhecker).

[Mike Griese (zadjii-msft)]

#shipit

[Deleted user (ghost)]

Hello Dustin L. Howett (@DHowett)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[Deleted user (ghost)]

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download