Command palette and search box visual tweaks · Pull Request #12913 · microsoft/terminal

Deleted user (ghost) · 2022-04-15T19:30:08Z

Tweaked command palette and search box to better match the Windows 11 Fluent design:

Now styled like a normal flyout, with acrylic, shadow and border
TextBox now uses default style
Tweaked button and key chord designs
Adjusted spacing

Fixes #12968.

Mike Griese (zadjii) · 2022-04-15T21:46:25Z

Wow I friggin love it. I'm offline for the weekend already, but lemme ping the team on Monday.

Dustin L. Howett (DHowett) · 2022-04-18T18:06:28Z

I, too, love this! Holy wow!

Dustin L. Howett (DHowett) · 2022-04-18T18:14:45Z

I somewhat prefer the first design, as it is consistent with the search box and what VSCode does. Giving the controls some space affords us some visual distance between the shadow, tab content and search.

How does the list look in tab switcher mode? (by default, Ctrl+Tab will trigger it; keep holding down Ctrl to see the switcher)

Dustin L. Howett (DHowett) · 2022-04-18T20:25:18Z

Ah, and how does this look in "commandline" mode? If you backspace the implicit > it will change the UI up a bit.

Deleted user (ghost) · 2022-04-19T00:23:49Z

The tab switcher has a weird space at the top, I'll try to fix it.

Mike Griese (zadjii-msft) · 2022-04-21T11:52:24Z

This is gorgeous, I love it so much

For those playing along in HC mode

Dustin L. Howett (DHowett) · 2022-04-21T22:36:48Z

I think this is waiting on the fix for the tab switcher top gap, right? I'm happy to review it still! I love it so much.

Deleted user (ghost) · 2022-04-22T11:30:56Z

I fixed the spacing, but there is still a crash happening sometimes when typing and deleting text inside the command palette. It can be easily replicated by typing >, backspace, >.

Mike Griese (zadjii-msft) · 2022-04-25T12:05:00Z

I fixed the spacing, but there is still a crash happening sometimes when typing and deleting text inside the command palette. It can be easily replicated by typing >, backspace, >.

I'll try debugging this more later today. Wild that it doesn't even like give a useful stack trace - it just explodes 🤔

Mike Griese (zadjii-msft) · 2022-04-25T15:51:50Z

0:000> !xamlstowed
-------------------------
Callstack for hr=88000fa8 - AG_E_LAYOUT_CYCLE

Oh no. This won't be simple to diagnose. Lemme eye up the diff a bit closer, see if there's something that stands out.

Deleted user (ghost) · 2022-04-26T04:23:55Z

The issue happens when MinHeight in _filteredActionsView has values from 5 to 13. There's a connection to the negative padding, but I'm not sure why a key combination causes this.

Mike Griese (zadjii-msft) · 2022-04-27T11:49:48Z

The issue happens when MinHeight in _filteredActionsView has values from 5 to 13. There's a connection to the negative padding, but I'm not sure why a key combination causes this.

I suspect it has nothing to do with the key combo, but more about the showing/hiding/showing of certain UI elements. XAML can be finicky like that sometimes. At this point, we might just need to mess with the padding and general spacing to try and work around this.

Mike Griese (zadjii-msft)

(apparently I had a review in progress).

Mostly, notes on the MinHeight thing.

Mike Griese (zadjii-msft) · 2022-04-21T12:00:52Z

-                    <!--  Remove when implementing WinUI 2.6  -->
-                    <Thickness x:Key="FlyoutContentPadding">12</Thickness>
+                    <!--  Shadow that can be used by any control.  -->
+                    <ThemeShadow x:Name="SharedShadow" />


this is so brilliant. This is what our life would be like if we had people who actually knew how to use XAML ☺️

Mike Griese (zadjii-msft) · 2022-04-21T12:02:01Z

                CornerRadius="{ThemeResource OverlayCornerRadius}"
                Orientation="Horizontal"
-                Style="{ThemeResource SearchBoxBackground}">
+                Shadow="{StaticResource SharedShadow}"


As a future note to self - if we ever do productize the WinUI Terminal control, we'll need to edit this, but that is DEFINITELY not a concern for now.

Mike Griese (zadjii-msft) · 2022-04-27T16:52:40Z


            <ListView x:Name="_filteredActionsView"
                      Grid.Row="2"
+                      MinHeight="8"


I suppose here's a thought - why do we need this MinHeight at all? Setting it to 0 seems to mitigate the crash, and I don't know what it's needed for. At least, my eyes aren't sensitive enough to see what this changes...

Deleted user (ghost) · 2022-04-29T09:29:04Z

That was because of a very small issue: when the list is empty, it still takes up space (6px), when it should be collapsed. I made it 8px to look more balanced, but I'll revert that.

Deleted user (ghost) · 2022-04-29T09:46:10Z

All CLA requirements met.

Mike Griese (zadjii-msft)

LGTM. Thanks for the persistence debugging that MinHeight crash - that kind of thing would have drove me crazy!

Deleted user (ghost) · 2022-04-29T11:57:13Z

Hello Mike Griese (@zadjii-msft)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Tweaked command palette and search box to better match the Windows 11 Fluent design: * Now styled like a normal flyout, with acrylic, shadow and border * TextBox now uses default style * Tweaked button and key chord designs * Adjusted spacing Fixes #12968. ![searchlight](https://user-images.githubusercontent.com/101892345/163623805-3b860942-7e2e-401e-8739-3a966cf2b4a9.png) ![palettelight](https://user-images.githubusercontent.com/101892345/163623825-b1f187fa-557b-4921-86bc-4040ffd2952f.png) ![searchdark](https://user-images.githubusercontent.com/101892345/163623820-b3b7b138-d9af-4aae-a637-8e48717ddd2c.png) ![palettedark](https://user-images.githubusercontent.com/101892345/163623830-448354e6-6b37-4dbe-8cb4-e9275aa56322.png) (cherry picked from commit b63102f) Service-Card-Id: 81805346 Service-Version: 1.13

Deleted user (ghost) · 2022-05-24T17:03:24Z

🎉Windows Terminal v1.13.1143 has been released which incorporates this pull request.:tada:

Handy links:

Deleted user (ghost) · 2022-05-24T17:07:41Z

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

Search boxes visual tweaks

8f44609

Remove contract check

9c9b981

Mike Griese (zadjii-msft) added the Needs-Discussion Something that requires a team discussion before we can proceed label Apr 18, 2022

Mike Griese (zadjii-msft) mentioned this pull request Apr 21, 2022

Productize the WPF, UWP Terminal Controls #6999

Open

14 of 22 tasks

Fix spacing

4a01fb8

Mike Griese (zadjii-msft) self-assigned this Apr 25, 2022

Mike Griese (zadjii-msft) added Product-Terminal The new Windows Terminal. Area-CmdPal Command Palette issues and features and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Apr 25, 2022

Mike Griese (zadjii-msft) requested changes Apr 27, 2022

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 27, 2022

Mike Griese (zadjii-msft) removed their assignment Apr 27, 2022

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 29, 2022

Fix crash and bug

fc00be1

ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. labels Apr 29, 2022

ghost added the Priority-2 A description (P2) label Apr 29, 2022

Mike Griese (zadjii-msft) approved these changes Apr 29, 2022

View reviewed changes

Mike Griese (zadjii-msft) added the Needs-Second It's a PR that needs another sign-off label Apr 29, 2022

ghost requested review from Dustin L. Howett (DHowett), PankajBhojwani, Carlos Zamora (carlos-zamora) and Leonard Hecker (lhecker) April 29, 2022 11:11

Leonard Hecker (lhecker) approved these changes Apr 29, 2022

View reviewed changes

Mike Griese (zadjii-msft) added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 29, 2022

ghost merged commit b63102f into microsoft:main Apr 29, 2022

Mike Griese (zadjii-msft) mentioned this pull request May 5, 2022

Epic: Search v2 #3920

Open

13 of 20 tasks

ghost mentioned this pull request May 24, 2022

"No matching commands" overlaps Back button in nested command palette #12968

Closed

ghost deleted the search-visual-tweaks branch September 1, 2022 20:13

This pull request was closed.

Conversation

Deleted user (ghost) commented Apr 15, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mike Griese (zadjii) commented Apr 15, 2022

Uh oh!

Dustin L. Howett (DHowett) commented Apr 18, 2022

Uh oh!

Dustin L. Howett (DHowett) commented Apr 18, 2022

Uh oh!

Dustin L. Howett (DHowett) commented Apr 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Apr 19, 2022

Uh oh!

Mike Griese (zadjii-msft) commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dustin L. Howett (DHowett) commented Apr 21, 2022

Uh oh!

Deleted user (ghost) commented Apr 22, 2022

Uh oh!

Mike Griese (zadjii-msft) commented Apr 25, 2022

Uh oh!

Mike Griese (zadjii-msft) commented Apr 25, 2022

Uh oh!

Deleted user (ghost) commented Apr 26, 2022

Uh oh!

Mike Griese (zadjii-msft) commented Apr 27, 2022

Uh oh!

Mike Griese (zadjii-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Mike Griese (zadjii-msft) Apr 21, 2022

Choose a reason for hiding this comment

Uh oh!

Mike Griese (zadjii-msft) Apr 21, 2022

Choose a reason for hiding this comment

Uh oh!

Mike Griese (zadjii-msft) Apr 27, 2022

Choose a reason for hiding this comment

Uh oh!

Deleted user (ghost) commented Apr 29, 2022

Uh oh!

Deleted user (ghost) commented Apr 29, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mike Griese (zadjii-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Deleted user (ghost) commented Apr 29, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Deleted user (ghost) commented May 24, 2022

Uh oh!

Deleted user (ghost) commented May 24, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Deleted user (ghost) commented Apr 15, 2022 •

edited by ghost

Loading

Dustin L. Howett (DHowett) commented Apr 18, 2022 •

edited

Loading

Mike Griese (zadjii-msft) commented Apr 21, 2022 •

edited

Loading

Deleted user (ghost) commented Apr 29, 2022 •

edited by ghost

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.