Repository navigation
Fix showing a dialog multiple times - #12625
Merged
4 commits merged intoMar 10, 2022
Merged
4 commits merged into
4 commits merged into
Conversation
ghost
added
Area-UserInterface
Comment on lines
+384
to
+386
| // GH#12622: After the dialog is displayed, always clear it out. If we | ||
| // don't, we won't be able to display another! | ||
| _dialog = nullptr; |
Member
There was a problem hiding this comment.
Above it says
_dialog = dialog;To make this code robust against exceptions and future early returns I'd suggest changing it to:
_dialog = dialog;
const auto cleanup = wil::scope_exit([this]() {
_dialog = nullptr;
});...and revert this new code.
Dustin L. Howett (DHowett)
approved these changes
Mar 9, 2022
Dustin L. Howett (DHowett)
added
the
AutoMerge
|
Hello Dustin L. Howett (@DHowett)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Leonard Hecker (lhecker)
approved these changes
Mar 10, 2022
ghost
deleted the
dev/migrie/b/12622-paste-paste
branch
March 10, 2022 14:16
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Mar 10, 2022
Mike Griese (zadjii-msft)
added a commit
that referenced
this pull request
Mar 10, 2022
|
🎉 Handy links: |
ghost
mentioned this pull request
Mike Griese (zadjii-msft)
added a commit
that referenced
this pull request
Apr 6, 2022
This reverts commit 2e78ebf.
4 tasks done
ghost
pushed a commit
that referenced
this pull request
Apr 6, 2022
…#12840) After switching to ControlsV2, it seems that delay-loading a dialog causes the ContentDialog to be assigned a Height equal to it's content size. If we DON'T assign the ContentDialog a Row, I believe it's assigned Row 0 by default. So, when the dialog gets opened, the dialog seemingly causes a giant hole to appear in the body of the app. Assigning all the dialogs to Row 2 (where the rest of the content is) makes the "hole" appear in the same space as the rest of the TabContent, fixing the issue. Note that the actual content in a content dialog gets parented to the PopupRoot, so it actually always appeared in the correct place, it's just this weird hole that appeared in Row 0. * [x] Closes #12775 * See also: * #12202 was fixed by #12208 * #12447 was fixed by #12517 * [x] Tested manually * [x] Reverts #12625 * [x] Reverts #12517
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Apr 6, 2022
…#12840) After switching to ControlsV2, it seems that delay-loading a dialog causes the ContentDialog to be assigned a Height equal to it's content size. If we DON'T assign the ContentDialog a Row, I believe it's assigned Row 0 by default. So, when the dialog gets opened, the dialog seemingly causes a giant hole to appear in the body of the app. Assigning all the dialogs to Row 2 (where the rest of the content is) makes the "hole" appear in the same space as the rest of the TabContent, fixing the issue. Note that the actual content in a content dialog gets parented to the PopupRoot, so it actually always appeared in the correct place, it's just this weird hole that appeared in Row 0. * [x] Closes #12775 * See also: * #12202 was fixed by #12208 * #12447 was fixed by #12517 * [x] Tested manually * [x] Reverts #12625 * [x] Reverts #12517 (cherry picked from commit c4e5ebf) Service-Card-Id: 80266902 Service-Version: 1.12
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Apr 6, 2022
…#12840) After switching to ControlsV2, it seems that delay-loading a dialog causes the ContentDialog to be assigned a Height equal to it's content size. If we DON'T assign the ContentDialog a Row, I believe it's assigned Row 0 by default. So, when the dialog gets opened, the dialog seemingly causes a giant hole to appear in the body of the app. Assigning all the dialogs to Row 2 (where the rest of the content is) makes the "hole" appear in the same space as the rest of the TabContent, fixing the issue. Note that the actual content in a content dialog gets parented to the PopupRoot, so it actually always appeared in the correct place, it's just this weird hole that appeared in Row 0. * [x] Closes #12775 * See also: * #12202 was fixed by #12208 * #12447 was fixed by #12517 * [x] Tested manually * [x] Reverts #12625 * [x] Reverts #12517 (cherry picked from commit c4e5ebf) Service-Card-Id: 80266903 Service-Version: 1.13
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the dialog is displayed, always clear it out. If we don't, we won't be able to display another!