Repository navigation
Fix toggle switches needing a negative margin - #12381
Merged
2 commits merged intoFeb 5, 2022
Merged
2 commits merged into
2 commits merged into
Conversation
Carlos Zamora (carlos-zamora)
approved these changes
Feb 4, 2022
Michael Niksa (miniksa)
approved these changes
Feb 5, 2022
Dustin L. Howett (DHowett)
approved these changes
Feb 5, 2022
Member
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello Dustin L. Howett (@DHowett)! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
deleted the
dev/pabhoj/sui_language
branch
February 5, 2022 00:54
8 of 12 tasks
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Feb 9, 2022
## Summary of the Pull Request Reducing the `MinWidth` of a toggle switch means it no longer needs a negative margin to align it correctly ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Setting a different language no longer causes the toggle switch to fall out of the expander (cherry picked from commit 64efa67)
|
🎉 Handy links: |
Mike Griese (zadjii-msft)
pushed a commit
that referenced
this pull request
Mar 3, 2022
## Summary of the Pull Request Reducing the `MinWidth` of a toggle switch means it no longer needs a negative margin to align it correctly ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Setting a different language no longer causes the toggle switch to fall out of the expander
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Reducing the
MinWidthof a toggle switch means it no longer needs a negative margin to align it correctlyPR Checklist
Validation Steps Performed
Setting a different language no longer causes the toggle switch to fall out of the expander