Skip to content

Fix invoking the rightmost breadcrumb bringing you back to Profiles_Base - #12376

Merged
1 commit merged into
mainfrom
dev/pabhoj/breadcrumb_fix
Feb 7, 2022
Merged

1 commit merged into
mainfrom
dev/pabhoj/breadcrumb_fix

Conversation

@PankajBhojwani

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

We no longer do anything when the rightmost breadcrumb is invoked

PR Checklist

Validation Steps Performed

Tested manually, cannot repro #12325 anymore

@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Feb 4, 2022
@DHowett Dustin L. Howett (DHowett) added the AutoMerge Marked for automatic merge by the bot when requirements are met label Feb 7, 2022
@ghost

Copy link
Copy Markdown

Hello Dustin L. Howett (@DHowett)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
ghost merged commit 527b9cd into main Feb 7, 2022
@ghost
ghost deleted the dev/pabhoj/breadcrumb_fix branch February 7, 2022 18:06
Dustin L. Howett (DHowett) pushed a commit that referenced this pull request Feb 9, 2022
…ase (#12376)

## Summary of the Pull Request
We no longer do anything when the rightmost breadcrumb is invoked

## PR Checklist
* [x] Closes #12325
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Tested manually, cannot repro #12325 anymore

(cherry picked from commit 527b9cd)
@ghost

Copy link
Copy Markdown

🎉Windows Terminal Preview v1.13.10395.0 has been released which incorporates this pull request.:tada:

Handy links:

Mike Griese (zadjii-msft) pushed a commit that referenced this pull request Mar 3, 2022
…ase (#12376)

## Summary of the Pull Request
We no longer do anything when the rightmost breadcrumb is invoked

## PR Checklist
* [x] Closes #12325 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Tested manually, cannot repro #12325 anymore
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SUI Breadcrumbs should have better keyboard navigation

3 participants