Repository navigation
Make the SearchBox announce if it found results or not - #12301
3 commits merged into
Conversation
ghost
added
Area-Accessibility
This comment has been minimized.
This comment has been minimized.
| TYPED_EVENT(RaiseNotice, IInspectable, Control::NoticeEventArgs); | ||
| TYPED_EVENT(TransparencyChanged, IInspectable, Control::TransparencyChangedEventArgs); | ||
| TYPED_EVENT(ReceivedOutput, IInspectable, IInspectable); | ||
| TYPED_EVENT(FoundMatch, IInspectable, Control::FoundResultsArgs); |
There was a problem hiding this comment.
manual spacing is off here
| <value>Read-only mode is enabled.</value> | ||
| </data> | ||
| <data name="SearchBox_MatchesAvailable" xml:space="preserve"> | ||
| <value>Results found</value> |
There was a problem hiding this comment.
should we add comments explaining that these are read aloud to users using screen readers?
ghost
added
Needs-Author-Feedback
| { | ||
| Double Opacity { get; }; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: extra newline
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello Dustin L. Howett (@DHowett)! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Basically, this is the same as #12266, but for the `SearchBoxControl`. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it. * [x] Will take care of #11973 once a11y team confirms * [x] Tested manually with Narrator * [x] Resolves a part of #6319, which I'm repurposing just to displaying the number of results in general. * See also #3920 (cherry picked from commit fbe0416)
|
🎉 Handy links: |
|
🎉 Handy links: |
Basically, this is the same as #12266, but for the
SearchBoxControl. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it.