Repository navigation
CLS should reset the virtual viewport bottom #9872
Description
Windows Terminal version (or Windows build number)
Other Software
No response
Steps to reproduce
- Make sure you're using a build with PR Prevent the virtual viewport bottom being moved up unintentionally #9770 merged.
- Open a conhost cmd shell.
- Output some content to fill a few pages of the buffer.
- Execute
cls.
Expected Behavior
The buffer should be cleared and the viewport should be moved back to the top of the buffer.
Actual Behavior
The buffer is cleared, but the viewport remains where it was before the cls.
I'm afraid I broke this with PR #9770. Previously cls would have reset the virtual bottom when it reset the viewport, but it doesn't do that anymore. And I suspect there are probably more cases like this.
I'm really not sure what the right solution is though - maybe every viewport change made through the console API should reset the virtual bottom? But whatever we do, there are going to be some cases that behave weirdly - I think that's inevitable when you're mixing the legacy APIs with VT.
For now, though, I think it might be a good idea to revert #9770, because this bug seems a lot worse than #9754.
Activity
DHowett commentedon Apr 28, 2021
Thanks for this. Sorry for the delay here -- we're getting to the end of a Windows dev cycle and by now you've probably guessed that that tends to eclipse the sun. 😄
I'll revert 9770 on main.
Prevent the virtual viewport bottom being updated incorrectly (#12972)
Revert "Prevent the virtual viewport bottom being moved up unintentio…