Skip to content

Progress state doesn't update correctly between panes #9743

Closed

Description

  1. Set the progress to indeterminate state in a pane.
  2. Open a new tab. Note that the taskbar and tabs display as expected.
  3. Switch back to the first tab. Note that the taskbar and tabs display as expected.
  4. Open a new pane. Note that the tab and taskbar still display the progress state!
  5. Switch to the second tab. Note that the taskbar and tabs display as expected.
  6. Switch back to the first tab. Note that the taskbar and tabs display as expected. (no progress, because the second pane does not have progress state)
  7. Switch to the first pane. Note that the tab and taskbar still have no progress state!

Seemingly the progress state doesn't update when the active pane changes, only when the active tab does.

I might have a fix for this that's paired with #6842, but do we want to bite off a 30 file PR just for this fix?

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Apr 7, 2021
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 7, 2021
  3. DHowett commented on Apr 7, 2021

    @DHowett
    Member

    do we want to bite off

    Well, not exactly, but one takes the fix out of the 30 file PR ;)

  4. added
    Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    on Apr 7, 2021
  5. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 7, 2021
  6. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Apr 7, 2021
  7. added a commit that references this issue on Apr 8, 2021
    d8beada
  8. Don-Vito commented on Apr 12, 2021

    @Don-Vito
    Contributor

    I guess I don't fully understand the logic, but I am not sure why TaskbarProgressChanged is not called upon pane activation. I will create a draft PR with this :)

  9. ghost added
    In-PRThis issue has a related PR
    on Apr 12, 2021
  10. ghost closed this as completedin #9779on Apr 12, 2021
  11. ghost added a commit that references this issue on Apr 12, 2021
    ca9e5e0
  12. ghost removed
    In-PRThis issue has a related PR
    on Apr 12, 2021
  13. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Apr 12, 2021
  14. added a commit that references this issue on Apr 12, 2021
    17f9dbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-2A description (P2)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions