[BASH] Window Rename TeachingTip does not handle mixed system + terminal theme #9717

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Apr 6, 2021
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Apr 6, 2021
3. Mike Griese (zadjii-msft)

   added

   Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssues pertaining to the user interface of the Console or Terminal

   Priority-3A description (P3)A description (P3)

   on Apr 6, 2021
4. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Apr 6, 2021
5. zadjii-msft commented on Apr 6, 2021

   

   Mike Griese (zadjii-msft)

   on Apr 6, 2021

   Member

   More actions

   
6. Mike Griese (zadjii-msft)

   added this to the Terminal v2.0 milestone on Apr 6, 2021
7. zadjii-msft commented on Apr 6, 2021

   

   Mike Griese (zadjii-msft)

   on Apr 6, 2021

   Member

   More actions

   Oh my god:
   

   Just naively setting RequestedTheme on the TeachingTip is not good enough. Apparently that doesn't cascade down to contents of the TeachingTip??
8. ghost added

   In-PRThis issue has a related PRThis issue has a related PR

   on Apr 6, 2021
9. Mike Griese (zadjii-msft)

   removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Apr 6, 2021
10. ghost closed this as completedin #9732on Apr 7, 2021
11. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Apr 7, 2021
12. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Apr 7, 2021
13. ghost added a commit that references this issue on Apr 7, 2021

    Match the RequestedTheme of our TeachingTips to the set `theme` (#9732)

    ...

    This issue will close once commit 361877c is merged into the 'main' branch.

    361877c