Repository navigation
OSC 9;9 path seems to be invalid #8930
Description
Environment
Windows build number: Microsoft Windows [Version 10.0.19042.746]
Windows Terminal version (if applicable): 1.6.10272.0
Any other software?
Powershell Core & Powershell 5
Steps to reproduce
I was trying out the new out the new OSC 9;9 reporting in the 1.6 release of the terminal and it seems that when I try to duplicate a pane after setting the path using OSC 9;9 the terminal can never find the location of the path set and shows the error 0x8007010b error.
In my case I have altered my terminal launch profile for powershell to include the -noprofile parameter for easier testing.
Expected behavior
- Launch Powershell in terminal
- Run the following
cd 'C:\Program Files\'
"$([char]27)]9;9;`"$($pwd.Path)`"$([char]7)"- Run duplicate pane command
- New pane should open in
C:\Program Files
Actual behavior
It is important to note that performing the exact same set of commands in ConEmu will correctly open the new pane in Program Files as expected.
Other Notes
Powershell Launch Profile:
{
"guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
"hidden": false,
"name": "PowerShell Core",
"source": "Windows.Terminal.PowershellCore",
"commandline" : "C:\\Program Files\\PowerShell\\7\\pwsh.exe -noprofile",
}Duplicate pane key bind:
{ "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
Activity
zadjii-msft commentedon Jan 28, 2021
ho boy that sure looks wrong
Hmm.
I wonder if the double-quotes wrapping the string are confusing it.
/cc Chester Liu (@skyline75489)
jack775544 commentedon Jan 28, 2021
Removing the double quotes does seem to fix the issue however the implementation that I saw in oh-my-posh as well as the ConEmu docs both seemed to imply that the double quotes are intended.
skyline75489 commentedon Jan 28, 2021
Thanks for trying out the feature! I didn’t know there’s OSC;9;9 implementation in oh-my-posh until now. I was baking my own implementation so obviously it is not tested that much. Will take a look today.
Improve OSC 9;9 parsing logic & add tests (#8934)
Improve OSC 9;9 parsing logic & add tests (#8934)