Skip to content

Add automation properties to Settings UI #8899

Closed

Description

Description of the new feature/enhancement

We need to add automation properties throughout the settings UI. Here are a few examples that really need to be addressed:

  • Profile > Appearance > background image alignment control
  • color schemes > buttons
  • Startup > default profile > combo box items
  • (unverified) Profile/ColorSchemes > Delete button (and any other buttons with icons)

Proposed technical implementation details (optional)

The general approach to adding automation properties is to add something like this to the resw file:

<data name="Profile_BackgroundImageAlignmentBottom.[using:Windows.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
	<value>Align to Bottom</value>
</data>

However, this causes some localization burden, and since the help text will most likely match the tooltip, it would be more ideal if we could reuse the same resw entry. This would ensure that they're always in sync.

I think CommandPalette had to do something similar to this.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jan 26, 2021
  2. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jan 26, 2021
  3. ghost added a commit that references this issue on Feb 8, 2021
  4. ghost added a commit that references this issue on Feb 17, 2021
  5. ghost added
    In-PRThis issue has a related PR
    on Feb 18, 2021
  6. ghost closed this as completedin #9196on Feb 19, 2021
  7. ghost added a commit that references this issue on Feb 19, 2021
    bb0e1d3
  8. ghost removed
    In-PRThis issue has a related PR
    on Feb 19, 2021
  9. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-SettingsUIAnything specific to the SUIIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions