Skip to content

Links/URLs get offset when certain unicode characters are printed #8709

Closed

Description

@Entrivax

Environment

Windows build number: Windows 10 version 2004 (10.0.19041.0)
Windows Terminal version: Preview 1.5.3242.0

Steps to reproduce

Print certain unicode characters like this one: 𝓐

Expected behavior

Links/URLs should be valid.

Actual behavior

Links/URLs get offset and break with the presence of certain unicode characters.
For example, if the following text is printed:

𝓐𝓐𝓐
https://microsoft.com/

image

The hoverable link, clickable link and opened link is ps://microsoft.com/
If those unicode characters are not printed (if you scroll for example), the links work again.

2021-01-05_22-44-13_kWeoQrwJie.mp4

Note that the emoji doesn't cause the issue.
The code used in the video is:

console.log(`𝓐𝓐𝓐𝓐𝓐𝓐 123 https://microsoft.com/

✨ https://google.com/
https://google.fr/
https://youtube.com/
https://aka.ms/`)

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jan 5, 2021
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 5, 2021
  3. zadjii-msft commented on Jan 6, 2021

    @zadjii-msft
    Member

    Oh weird. I would have thought this was a dupe of #8121, but that one was fixed in 1.5.3142, so this must be it's own variation on the subject.

    Those 𝓐 characters are really messing it up, huh.

  4. added
    Area-RenderingText rendering, emoji, complex glyph & font-fallback issues
    Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    on Jan 6, 2021
  5. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 6, 2021
  6. Entrivax commented on Jan 6, 2021

    @Entrivax
    Author

    It looks a lot like it, going the other way from the screen of that issue.

    Those 𝓐 characters are really messing it up, huh.

    Yeah, I found the problem when printing display usernames from an api. Not only the 𝓐 character, but also the rest of the alphabet written like that. Maybe there is more characters than that, I didn't try to find them all.

  7. skyline75489 commented on Jan 9, 2021

    @skyline75489
    Collaborator

    The 𝓐 is considered as two wide chars because of #8124. Another place we might want to use a comprehensive Unicode width estimator .

  8. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jan 22, 2021
  9. zed76r commented on May 10, 2021

    @zed76r

    image

    image

  10. 1 remaining item

  11. ghost added
    In-PRThis issue has a related PR
    on Dec 9, 2021
  12. ghost closed this as completedin #11915on Dec 9, 2021
  13. ghost removed
    In-PRThis issue has a related PR
    on Dec 9, 2021
  14. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Dec 9, 2021
  15. ghost added a commit that references this issue on Dec 9, 2021
    a2d96d6
  16. added 2 commits that reference this issue on Dec 13, 2021
    9c5d997
    1ce8424
  17. DHowett commented on Dec 14, 2021

    @DHowett
    Member

    Clever quick fix -- thanks Comzyh (@comzyh)! I'm rolling this into the 1.11 and 1.12 servicing releases we're putting out to make Terminal more robust over the holidays. :)

  18. CerebralDatabank commented on Mar 28, 2024

    @CerebralDatabank

    I'm still having this issue with 5-digit Nerd Font Unicode characters on Windows 11…

    image

  19. DHowett commented on Mar 28, 2024

    @DHowett
    Member

    Which version of Terminal are you using? This issue was closed two years ago 🙂

  20. j4james commented on Mar 28, 2024

    @j4james
    Collaborator

    Dustin L. Howett (@DHowett) I think this regressed recently, because I was able to reproduce the issue until I got the update from 3 days ago. I'm assuming it was fixed by this:

    Auto-detected URLs and search results are no longer pushed around by wide characters (oops) (#16787)

    Gopal Othayoth (@CerebralDatabank) Bottom line is you probably just need to get the very latest update.

  21. CerebralDatabank commented on Mar 28, 2024

    @CerebralDatabank

    Dustin L. Howett (@DHowett) Haha I knew that, but what can I say, I still have the issue 😅 thought replying here was better than opening a duplicate lol

    James Holderness (@j4james) I think you're right, latest stable is v1.19.10821.0 and I have v1.19.10573.0. But nothing happens when I check for updates in Terminal and there's no "Update" in the Store page.

    If I install the latest release via the .msixbundle from here, will that mess up the existing link with MS Store updates? Or should I just wait until it rolls out to my device?

  22. DHowett commented on Mar 28, 2024

    @DHowett
    Member

    thought replying here was better

    you know what, that's totally fair! hah!

    will that mess up the ... link

    Nope, you can install the msixbundle from here and it will still hook up to the store for future updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesArea-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issue-BugIt either shouldn't be doing this or needs an investigation.Priority-2A description (P2)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions