Skip to content

Teach CommandPalette to natively support tabs and command lines #8415

Open

Description

@Don-Vito

Description of the new feature/enhancement

Currently command palette has a single set of UIEelements that present different sets of Commands. This approach has a lot of gaps:

  1. To support tabs and command lines we need to convert them into Commands. This leads to extra complexity in maintaining model correctness (e.g., every time we reorder tabs we need to fix the relevant command as well).
  2. The same element reuse for different purposes makes CommandPalette complex (you need to reconfigure the control upon every mode switching). It also causes undesired re-computations.

Proposed technical implementation details (optional)

My plan to achieve it gradually is following:

Activity

  1. added
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Nov 27, 2020
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 27, 2020
  3. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 27, 2020
  4. Don-Vito commented on Nov 27, 2020

    @Don-Vito
    ContributorAuthor

    Dustin L. Howett (@DHowett) - can you please assign this one to me? 😊

  5. DHowett commented on Nov 27, 2020

    @DHowett
    Member

    Happy to 😄 thanks

  6. added
    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 29, 2020
  7. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-CmdPalCommand Palette issues and featuresArea-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Product-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions