Skip to content

Ligatures do not render under cursor column in Vim #800

New issue
New issue
Closed
Closed
Ligatures do not render under cursor column in Vim#800
Labels
Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-ReproWe can't figure out how to make this happen. Please help find a simplified repro.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.
Milestone
Backlog

Description

@miniksa
Michael Niksa (miniksa)
opened on May 14, 2019

Ported from internal customer feedback bug MSFT:21185824

In Vim with cursorcolumn enabled, any ligature that falls under the cursor column does not get rendered. The ligature is correctly rendered either when there is nothing overlapping it, when the cursor is over it, or when under the cursor line (with cursorline enabled).
Screenshots attached of all four cases mentioned above.

Tested in Vim 8.1.1-744 in WSL Ubuntu 16.04.

Note, I can't find the screenshots. Needs repro again.

Activity

  1. Michael Niksa (miniksa)
    added
    Needs-ReproWe can't figure out how to make this happen. Please help find a simplified repro.
    Area-RenderingText rendering, emoji, complex glyph & font-fallback issues
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    on May 14, 2019

  2. DHowett-MSFT commented on May 14, 2019

    @DHowett-MSFT
    Dustin L. Howett (MSFT) (DHowett-MSFT)
    on May 14, 2019
    Contributor

    This was nathpete-msft.

  3. nathpete-msft commented on May 14, 2019

    @nathpete-msft
    nathpete-msft
    on May 14, 2019
    Contributor

    Here are screenshots of the four cases mentioned above:

    1. Ligature under cursor column
      image
    2. Ligature under cursor line
      image
    3. Ligature under cursor
      image
    4. Ligature under nothing
      image
  4. Michael Niksa (miniksa)
    added
    Mass-Chaos
    on May 17, 2019
  5. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on May 17, 2019
  6. Michael Niksa (miniksa)
    added
    Product-TerminalThe new Windows Terminal.
    and removed
    Mass-Chaos
    on May 17, 2019
  7. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on May 17, 2019
  8. Mike Griese (zadjii-msft)
    added this to the Terminal v1.0 milestone on Jun 19, 2019
  9. Kayla Cinnamon (cinnamon-msft)
    modified the milestones: Terminal v1.0, Terminal Backlog on Jan 28, 2020
  10. Kayla Cinnamon (cinnamon-msft)
    added
    v1-Scrubbed
    on Jan 28, 2020
  11. Michael Niksa (miniksa)
    self-assigned this
    on Jun 3, 2020
  12. Mike Griese (zadjii-msft)
    modified the milestones: Terminal Backlog, Backlog on Jan 4, 2022
  13. Dustin L. Howett (DHowett)
    removed
    v1-Scrubbed
    on Feb 7, 2022
  14. Michael Niksa (miniksa)
    removed their assignment
    on Mar 31, 2022

  15. lhecker commented on May 3, 2023

    @lhecker
    Leonard Hecker (lhecker)
    on May 3, 2023
    Member

    Huh, I suppose we missed this issue? The new AtlasEngine renderer does not have this problem and shipped in 1.13. You can optionally enable it in Windows Terminal in the Rendering settings, or otherwise use Windows Terminal Preview where it's enabled by default. The upcoming version 1.18 will further improve the quality of ligature rendering and should release later this month. Let me know if you need a preview build ahead of time!

  16. Leonard Hecker (lhecker)
    closed this as completedon May 3, 2023
  17. microsoft-github-policy-service
    added
    Needs-Tag-FixDoesn't match tag requirements
    on May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-ReproWe can't figure out how to make this happen. Please help find a simplified repro.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions