Skip to content

Some system-defined environment variables are undefined #7399

New issue
New issue
Closed
#7401
Closed
Some system-defined environment variables are undefined#7399
#7401
Labels
Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-1A description (P1)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-BlockingWe won't ship a release like this! No-siree.
Milestone
Terminal v1.3

Description

@nathpete-msft
nathpete-msft
opened on Aug 25, 2020

Environment

Windows build number: 10.0.20201.0
Windows Terminal version (if applicable): 1.3.2372.0

Any other software? Nope

Steps to reproduce

In Powershell: $Env:UserName

In cmd: echo %UserName%

It looks like this variable is defined here: HKEY_CURRENT_USER\Volatile Environment

There are a couple of other variables defined there that are also undefined: %USERDOMAIN% and %USERDNSDOMAIN%

This is only happing after updating to the preview version of Terminal 1.3. The variables are still defined in Terminal 1.2, and when running pwsh/Windows Powershell/cmd outside of Terminal.

Expected behavior

The variable should contain the current user name.

Actual behavior

The variable is undefined.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 25, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Aug 25, 2020

  3. DHowett commented on Aug 25, 2020

    @DHowett
    Dustin L. Howett (DHowett)
    on Aug 25, 2020
    Member

    Regressed w/ #7243.

  4. Dustin L. Howett (DHowett)
    added this to the Terminal v1.4 milestone on Aug 25, 2020
  5. Dustin L. Howett (DHowett)
    added
    Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interface
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Priority-1A description (P1)
    Product-TerminalThe new Windows Terminal.
    on Aug 25, 2020
  6. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Aug 25, 2020

  7. zadjii-msft commented on Aug 25, 2020

    @zadjii-msft
    Mike Griese (zadjii-msft)
    on Aug 25, 2020
    Member

    Should this block 1.3?

  8. Mike Griese (zadjii-msft)
    removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 25, 2020

  9. DHowett commented on Aug 25, 2020

    @DHowett
    Dustin L. Howett (DHowett)
    on Aug 25, 2020
    Member

    Yeah probably.

  10. Dustin L. Howett (DHowett)
    modified the milestones: Terminal v1.4, Terminal v1.3 on Aug 25, 2020
  11. Dustin L. Howett (DHowett)
    added
    Severity-BlockingWe won't ship a release like this! No-siree.
    on Aug 25, 2020

  12. DHowett commented on Aug 25, 2020

    @DHowett
    Dustin L. Howett (DHowett)
    on Aug 25, 2020
    Member

    Investigating: profile API does EXPLICITLY add these vars (!) so i bet it's my token code

  13. nathpete-msft
    added a commit that references this issue on Aug 25, 2020

    Fix environment block creation

    7ad3284
  14. ghost added
    In-PRThis issue has a related PR
    on Aug 25, 2020
  15. ghost closed this as completedin #7401on Aug 25, 2020
  16. ghost removed
    In-PRThis issue has a related PR
    on Aug 25, 2020
  17. ghost added a commit that references this issue on Aug 25, 2020

    Fix environment block creation (#7401)

    64f10a0
  18. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Aug 25, 2020
  19. Dustin L. Howett (DHowett)
    added a commit that references this issue on Aug 25, 2020

    Fix environment block creation (#7401)

    7886f16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-1A description (P1)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-BlockingWe won't ship a release like this! No-siree.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions