Repository navigation
Make all the ICoreSettings / IControlSettings properties getters-only #7219
Description
We've discussed this for a while now, but it's possible now this the other work Carlos is doing with settings.
I've got a WIP branch here: dev/migrie/f/settings-getters-only, with only a few errors.
I think for each of these, the TermControl is going to need to cache a local copy of the value, to represent it's actual runtime value, rather than use the IControlSettings as a buffer.
I'm filing this so someone else can pick that up where I left off.
Metadata
Metadata
Assignees
Labels
Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to settings and customizability, for console or terminalWe encourage anyone to jump in on these.It's a feature request, but it doesn't really need a major design.The new Windows Terminal.Fix is checked in, but it might be 3-4 weeks until a release.
Activity
MichelleTanPY commentedon Aug 26, 2020
Hi, I thought of picking this up, and made the changes according to the WIP dev branch there. But I got a lot of errors from multiple files complaining that the argument takes 1 parameters. Any pointers or examples ?
Thanks
zadjii-msft commentedon Aug 26, 2020
Michelle Tan (@MichelleTanPY) That's basically the whole task here actually. Currently, the
TermControlstashes a bunch of run time changes to the settings in it'sIControlSettingsobject. In that WIP branch, I made all the properties getters-only, but I haven't yet changedTermControlto do the right thing here. For any of the properties where there's a compile error, you'll need to change TermControl to have some member variable that it uses to store the runtime value instead.Change the `ControlCore` layer to own a copy of its settings (#11619)