Skip to content

VT SOS, APC & PM should be ignored until supported #7032

Closed

Description

Environment

Windows build number: 10.0.19041.388
Windows Terminal version (if applicable): 1.1.2021

Any other software? WSL

Steps to reproduce

Run the following bash command:

printf '\e_123123\e\\'

printf '\e^123123\e\\'

Expected behavior

Nothing is shown.

Actual behavior

The data string is printed:

>printf '\e_123123\e\\'
123123%

Detail

Coming from #120 and excellent comments of James Holderness (@j4james) on #6328 , it occurs to me that we should ignore APC and PM the same way as DCS.

Feel free to assign this issue to me as it's very likely to be the next thing in my plan.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 23, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 23, 2020
  3. changed the title [-]VT APC & PM should be ignored unless supported[/-] [+]VT APC & PM should be ignored until supported[/+] on Jul 23, 2020
  4. skyline75489 commented on Jul 23, 2020

    @skyline75489
    CollaboratorAuthor

    From the official doc of xterm here, SOS, APC & PM are recognized but no actual functions are implemented. So I guess we could do the same by simply recognizing the sequence and call it a day. Doing this will align the behavior of WT with other modern terminals.

  5. added
    Help WantedWe encourage anyone to jump in on these.
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    Product-ConhostFor issues in the Console codebase
    on Jul 23, 2020
  6. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 23, 2020
  7. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 24, 2020
  8. changed the title [-]VT APC & PM should be ignored until supported[/-] [+]VT SOS, APC & PM should be ignored until supported[/+] on Jul 24, 2020
  9. ghost added
    In-PRThis issue has a related PR
    on Aug 19, 2020
  10. ghost closed this as completedin #7340on Sep 16, 2020
  11. ghost removed
    In-PRThis issue has a related PR
    on Sep 16, 2020
  12. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Sep 16, 2020
  13. ghost added a commit that references this issue on Sep 16, 2020
    f91b53d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-VTVirtual Terminal sequence supportHelp WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Priority-3A description (P3)Product-ConhostFor issues in the Console codebaseResolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions