Skip to content

Move u8State from WriteConsoleAImpl to SCREEN_INFORMATION #6982

Open

Description

@german-one

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview

In #4493 Michael Niksa (@miniksa) pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to
#4493 (comment)
In the current code base it's still in WriteConsoleAImpl though.

static til::u8state u8State{};

Since I closed the PR I just don't want this information to get lost.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 20, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 20, 2020
  3. added
    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
    Help WantedWe encourage anyone to jump in on these.
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    Product-ConhostFor issues in the Console codebase
    on Jul 27, 2020
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 27, 2020
  5. DHowett commented on Jul 27, 2020

    @DHowett
    Member

    Thanks for filing this! I'm going to mark it up for the conhost backlog.

  6. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Help WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Priority-3A description (P3)Product-ConhostFor issues in the Console codebase

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions