Skip to content

Maybe add support for move-focus subcommand #6580

Closed

Description

I'm submitting this one for discussion - I don't think this deserves a spec, but maybe some discussion.

#5464 covers "Add support for focus-pane subcommand". That particular subcommand is tricky, because we'd need to have IDs for Panes, and then that gets into all sorts of discussion like should the ID be for the pane, or the TermControl?.

Since that's hard, I thought I might do something easy like move-focus, which is just the moveFocus action, turned into a wt subcommand. This comes with two caveats:

  • It would be subject to the same bug that moveFocus is, Use visual layout for moveFocusX target #2398.
  • It would behave non-deterministically with auto splits. The commandline might behave differently if a pane splits in a different direction due to a different initial window size. Official guidance would probably be "make sure to specify the split direction for all split-pane commands if you're using move-focus".

@microsoft/windows-console-team Are we okay with shipping this command with the above caveats?

I'm thinking the command is just

  • move-focus [direction]
    where direction is one of left, right, up, down.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jun 18, 2020
  2. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jun 18, 2020
  3. DHowett commented on Jun 18, 2020

    @DHowett
    Member

    So, when I was talking about how I wanted something more composable than a command that depends on physical location, I wasn't thinking about #4472. I'm not sure it makes sense as something that you can launch with, but... perhaps there's value in it.

  4. ghost added
    In-PRThis issue has a related PR
    on Dec 10, 2020
  5. ghost closed this as completedin #8546on Jan 11, 2021
  6. ghost removed
    In-PRThis issue has a related PR
    on Jan 11, 2021
  7. ghost added a commit that references this issue on Jan 11, 2021
    7235996
  8. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Jan 11, 2021
  9. added a commit that references this issue on Jan 28, 2021
    4bb6777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-Commandlinewt.exe's commandline argumentsIssue-QuestionFor questions or discussionProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions