Activity

1. Ricardo Bánffy (rbanffy)

   added

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   on May 19, 2020
2. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on May 19, 2020
3. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on May 19, 2020
4. Mike Griese (zadjii-msft)

   added

   Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesText rendering, emoji, complex glyph & font-fallback issues

   Area-VTVirtual Terminal sequence supportVirtual Terminal sequence support

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Product-ConhostFor issues in the Console codebaseFor issues in the Console codebase

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   on May 19, 2020
5. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on May 19, 2020
6. Mike Griese (zadjii-msft)

   removed

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   on May 19, 2020
7. Mike Griese (zadjii-msft)

   added this to the Console Backlog milestone on May 19, 2020
8. zadjii-msft commented on May 19, 2020

   

   Mike Griese (zadjii-msft)

   on May 19, 2020

   Member

   More actions

   Yep, we probably should.I'm mildly worried that the ExtendedAttributes enum used all the flags in a BYTE, but we'll figure it out.

   terminal/src/inc/conattrs.hpp

   Lines 11 to 24 in c78f264

   	enum class ExtendedAttributes : BYTE
   	{
   	Normal = 0x00,
   	Bold = 0x01,
   	Italics = 0x02,
   	Blinking = 0x04,
   	Invisible = 0x08,
   	CrossedOut = 0x10,
   	// TODO:GH#2916 add support for these to the parser as well.
   	Underlined = 0x20, // _technically_ different from LVB_UNDERSCORE, see TODO:GH#2915
   	DoublyUnderlined = 0x40, // Included for completeness, but not currently supported.
   	Faint = 0x80, // Included for completeness, but not currently supported.
   	};
   	DEFINE_ENUM_FLAG_OPERATORS(ExtendedAttributes);
9. DHowett commented on May 19, 2020

   

   Dustin L. Howett (DHowett)

   on May 19, 2020

   Member

   More actions

   So for this one we also have the LVB gridline attributes, technically. We need to figure out how they combine with underline/overline and grid bottom/top
10. j4james commented on May 19, 2020

    

    James Holderness (j4james)

    on May 19, 2020

    Collaborator

    More actions

    So for this one we also have the LVB gridline attributes, technically.

    Yeah, I was just going to suggest using the COMMON_LVB_GRID_HORIZONTAL for this as a quick fix. It's no worse than our current usage of COMMON_LVB_UNDERSCORE for underline. I hacked together a quick implementation to test, and it looked OK to me. I'm not exactly sure where the overline is supposed to be rendered, but Mintty at least seems to have it at the very top of the cell. Haven't checked other implementations yet.

    As for running out of bits in ExtendedAttributes , note that the lower byte of the _wAttrLegacy word is actually unused as far as I can tell, so we should have an additional 8 bits to play around with.

    👍React with 👍1Reacted by Ricardo Bánffy
11. DHowett commented on May 19, 2020

    

    Dustin L. Howett (DHowett)

    on May 19, 2020

    Member

    More actions

    Lower byte of ... legacy ...

    Holy crap! I never noticed this. That's clever/evil/cl-evil.
12. zadjii-msft commented on May 19, 2020

    

    Mike Griese (zadjii-msft)

    on May 19, 2020

    Member

    More actions

    I was just going to suggest using the COMMON_LVB_GRID_HORIZONTAL for this as a quick fix

    That's brilliant and I love it
13. Dustin L. Howett (DHowett)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on May 21, 2020
14. j4james commented on Jun 25, 2020

    

    James Holderness (j4james)

    on Jun 25, 2020

    Collaborator

    More actions

    FYI, I've got a branch with this implemented, but it's built on top of #6506, so I'll only be able to do a PR once that's merged, which may be a while.
15. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Jul 2, 2020
16. ghost closed this as completedin #6754on Jul 6, 2020
17. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Jul 6, 2020
18. ghost added a commit that references this issue on Jul 6, 2020

    Add support for the "overline" graphic rendition attribute (#6754)

    ...

    This issue will close once commit 70a7ccc is merged into the 'main' branch.

    70a7ccc
19. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Jul 6, 2020
21. DHowett commented on Aug 21, 2020

    

    Dustin L. Howett (DHowett)

    on Aug 21, 2020

    Member

    More actions

    🎉 As of Windows Insider build 20197, this is also supported in the traditional console.