Repository navigation
Lines that wrap on space characters at the bottom of the buffer (“new bottom line”) receive an extra line break #5386
Description
With 0.11.xxx selfhost builds, The following steps reliably result in visual corruption (and also drove me a little crazy!)
- Terminal width = 120
- Go to the terminal source tree
git blame 862793299a src/types/UiaTextRangeBase.cpp- Search for
GetTextRectsusing/:/GetTextRects<CR>
- Go to the next match, using
n. - Notice that
GetTextRects, which should be on the top line, is gone. - Move right, left (arrow keys), and notice that it reappears.
bad
good
If you look at the bad image, I highlighted two things that caught my eye. Those are lines that have spaces in column 121, before less hard wraps them (!) I don't have 121 columns ...
Confirmed this in a text editor with the debug tap. I highlighted in blue the same regions that caused a break here.
The vertical strip under the cursor (look for the blue boxes) indicates column 121. Most of the escape sequences for cursor movement start here, but in the boxed areas they're not escapes.
Is this the exact wrap issue? Except with conpty sending spaces instead?
Activity
DHowett-MSFT commentedon Apr 17, 2020
issue_5386_tap.txt
zadjii-msft commentedon Apr 17, 2020
I'm not sure, but I can take a look Monday? Unless you think this should interrupt the DX work I'm on now.
Either this is exact wrap, or more likely, this is an exclusive/inclusive thing. There's one spot in
PaintBufferLinethat's always been anExclusiveRightthat I've always thought should be anInclusiveRight, and maybe the other conpty changes finally broke that line.DHowett-MSFT commentedon Apr 17, 2020
Got this down to a perfect repo.
ConPTY will duplicate the single space into two spaces, causing a wrap on the Terminal side.
Don't duplicate spaces from potentially-wrapped EOL-deferred lines
[-]_Extremely specific_ repro with git blame causes terminal (pty?) to wrap lines too hard[/-][+]Lines that wrap on space characters at the bottom of the buffer (“new bottom line”) receive an extra line break[/+]Don't duplicate spaces from potentially-wrapped EOL-deferred lines (#…