Skip to content

Some kind of unicode regression #4704

New issue
New issue
Closed
#4731
Closed
Some kind of unicode regression#4704
#4731
Assignees
miniksa
Labels
Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-1A description (P1)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-BlockingWe won't ship a release like this! No-siree.
Milestone
Terminal v1.0

Description

@djdv
Dominic Della Valle (djdv)
opened on Feb 23, 2020

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 4420950337ccdd7bb5bb66d84538d2ea4195c101
Powershell 7-rc3

Steps to reproduce

After 4420950, characters like 🏠 appear to get corrupted.

I'm using this symbol in my Powershell prompt and it has stopped working as expected.
7d6738c:
001
4420950:
002

$script:pathDelim = [IO.Path]::DirectorySeparatorChar.ToString()
(@($pwd.Path.Split($pathDelim) | select-object -skip 1) -join  $pathDelim).replace([environment]::UserName, "🏠

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Feb 23, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Feb 23, 2020

  3. DHowett-MSFT commented on Feb 24, 2020

    @DHowett-MSFT
    Dustin L. Howett (MSFT) (DHowett-MSFT)
    on Feb 24, 2020
    Contributor

    Yeah, this is fairly serious. 😄

    Thanks!

    I bet it's part of the conpty change in 4420950.

    image

    function things {
write-host "🏠"
write-host "a🏠"
write-host "🏠b"
write-host "c🏠d"
}

    /cc Michael Niksa (@miniksa)

  4. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added
    Area-RenderingText rendering, emoji, complex glyph & font-fallback issues
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Severity-BlockingWe won't ship a release like this! No-siree.
    Product-TerminalThe new Windows Terminal.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Feb 24, 2020
  5. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Feb 24, 2020
  6. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added this to the Terminal v1.0 milestone on Feb 24, 2020
  7. Dustin L. Howett (MSFT) (DHowett-MSFT)
    assigned
    Michael Niksa (miniksa)
    on Feb 24, 2020
  8. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added
    Priority-1A description (P1)
    on Feb 25, 2020

  9. miniksa commented on Feb 26, 2020

    @miniksa
    Michael Niksa (miniksa)
    on Feb 26, 2020
    Contributor
    function things {
write-host "`u{1f3e0}"
write-host "a`u{1f3e0}"
write-host "`u{1f3e0}b"
write-host "c`u{1f3e0}d"
}

  10. miniksa commented on Feb 26, 2020

    @miniksa
    Michael Niksa (miniksa)
    on Feb 26, 2020
    Contributor

    SURROGATE PAIRS!

    shakes fist into air

  11. Michael Niksa (miniksa)
    added a commit that references this issue on Feb 26, 2020

    Don't split surrogate pairs when breaking runs for scaling. Affects e…

    f892200
  12. ghost added
    In-PRThis issue has a related PR
    on Feb 26, 2020
  13. ghost closed this as completedin #4731on Feb 26, 2020
  14. ghost added a commit that references this issue on Feb 26, 2020

    Don't split surrogate pairs when breaking runs for scaling. Affects e…

    d7ea526
  15. ghost removed
    In-PRThis issue has a related PR
    on Feb 26, 2020
  16. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Feb 26, 2020
  17. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added a commit that references this issue on Feb 28, 2020

    Revert "Don't split surrogate pairs when breaking runs for scaling. A…

    8fb90dc

  18. djdv commented on Mar 1, 2020

    @djdv
    Dominic Della Valle (djdv)
    on Mar 1, 2020
    Author

    Dustin L. Howett (MSFT) (@DHowett-MSFT) , Michael Niksa (@miniksa)
    Thanks for the render fix!
    However, this is still presenting an issue.
    If I set glyphs like that to be part of the prompt, I'm not able to actually use the shell (input seems to do nothing).
    Rendering them seems fine however.
    Example: https://youtu.be/5Dswxk6XdTs

    EDIT: spoke too soon
    This doesn't happen under #4747 (ddadcc5) but does in current master (4608fd0 ).

  19. miniksa commented on Mar 2, 2020

    @miniksa
    Michael Niksa (miniksa)
    on Mar 2, 2020
    Contributor

    Dustin L. Howett (MSFT) (@DHowett-MSFT) Dustin Howett FTE , Michael Niksa (@miniksa) Michael Niksa FTE
    Thanks for the render fix!
    However, this is still presenting an issue.
    If I set glyphs like that to be part of the prompt, I'm not able to actually use the shell (input seems to do nothing).
    Rendering them seems fine however.
    Example: youtu.be/5Dswxk6XdTs

    EDIT: spoke too soon
    This doesn't happen under #4747 (ddadcc5) but does in current master (4608fd0 ).

    OK, great. I'm trying to bring #4747 in ASAP, so hopefully this will be fully resolved for you then.

  20. ghost added a commit that references this issue on Mar 2, 2020

    Improve glyph scaling correction (#4747)

    7f43b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-RenderingText rendering, emoji, complex glyph & font-fallback issuesIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-1A description (P1)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-BlockingWe won't ship a release like this! No-siree.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions