Inconsistent gutters/margins on HiDPI displays with snapToGridOnResize

It looks like on my 200% scale device it's snapping at the half-grid.

A 50x15 window at 150% scale with Ctrl+Shift+A:

After resizing the window to 51x15:

At 125% scaling it seems to have a variable padding at the bottom. As you size the window up from the bottom, one line at a time, it actually shrinks the window by some lesser amount - probably 80% of a line.

Even at 100% it is not totally reliable. When you expand the height of the window the newly revealed line will sometimes not render (even though there is content there) but if you scroll up and down the content will appear.

terminal/src/cascadia/TerminalControl/TermControl.cpp

Lines 2415 to 2433 in 636be7e

    
           float TermControl::SnapDimensionToGrid(const bool widthOrHeight, const float dimension) 
        
           { 
        
               const auto fontSize = _core.FontSize(); 
        
               const auto fontDimension = widthOrHeight ? fontSize.Width : fontSize.Height; 
        
               const auto padding = GetPadding(); 
        
               auto nonTerminalArea = gsl::narrow_cast<float>(widthOrHeight ? 
        
                                                                  padding.Left + padding.Right : 
        
                                                                  padding.Top + padding.Bottom); 
        
               if (widthOrHeight && _core.Settings().ScrollState() != ScrollbarState::Hidden) 
        
               { 
        
                   nonTerminalArea += gsl::narrow_cast<float>(ScrollBar().ActualWidth()); 
        
               } 
        
               const auto gridSize = dimension - nonTerminalArea; 
        
               const auto cells = floor(gridSize / fontDimension); 
        
               return cells * fontDimension + nonTerminalArea; 
        
           }

Pretty sure this just doesn't account for DIPs vs pixels at all. Never has. I'd reckon that dimension is in DIPs and fontSize is in pixels. Someone could pretty easily fix that

I'm having this problem as well on a 4k display.
Used a white background to show the borders.
Is there any way to totally get rid of the borders from all sides?

Seeing that this is open for almost a year, is this still being worked on? As it seems its still relevant. #17721 mentions 1.23 as a potential candidate that adresses this, am I understanding correctly?

No, it's not. вт, 7 янв. 2025 г., 14:53 Marco Bueß ***@***.***>:

…

Seeing that this is open for almost a year, is this still being worked on? As it seems its still relevant. #17721 <#17721> mentions 1.23 as a potential candidate that adresses this, am I understanding correctly? — Reply to this email directly, view it on GitHub <#4175 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BOAUGLPLZMNA4QO3ABKCRX32JOPZHAVCNFSM6AAAAABUXK5C66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUHA2DKNBUGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

I'm still waiting for this to be fixed

5 years. Any progress on this?

Can confirm, still an issue with latest terminal version.

I would like to contribute on this as my first opensource project.
Can i?

Hi! I'd like to investigate and work on this issue as my first contribution to Windows Terminal.

I'll first reproduce the issue, inspect the current SnapDimensionToGrid implementation, and investigate the DIP-versus-pixel scaling behaviour before proposing a fix.

Please let me know if there are any specific considerations before I proceed. Thank you!

considerations

Follow our AI guidelines and we won't have a problem.

Navigation Menu

Repository navigation

Inconsistent gutters/margins on HiDPI displays with `snapToGridOnResize` #4175

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	float TermControl::SnapDimensionToGrid(const bool widthOrHeight, const float dimension)
	{
	const auto fontSize = _core.FontSize();
	const auto fontDimension = widthOrHeight ? fontSize.Width : fontSize.Height;

	const auto padding = GetPadding();
	auto nonTerminalArea = gsl::narrow_cast<float>(widthOrHeight ?
	padding.Left + padding.Right :
	padding.Top + padding.Bottom);

	if (widthOrHeight && _core.Settings().ScrollState() != ScrollbarState::Hidden)
	{
	nonTerminalArea += gsl::narrow_cast<float>(ScrollBar().ActualWidth());
	}

	const auto gridSize = dimension - nonTerminalArea;
	const auto cells = floor(gridSize / fontDimension);
	return cells * fontDimension + nonTerminalArea;
	}

Inconsistent gutters/margins on HiDPI displays with snapToGridOnResize #4175

Description

Activity

randomascii commented on Mar 28, 2020

14 remaining items

DHowett commented on Aug 22, 2023

egorlepa commented on Aug 25, 2023

zadjii-msft commented on Aug 31, 2023

rp1231 commented on Feb 22, 2024

MarcoBuess commented on Jan 7, 2025

Ali-Nu commented on Jan 7, 2025

B1LLP4RK commented on Jul 9, 2025

FY0u11 commented on Oct 15, 2025

kahilah commented on Dec 29, 2025

shivam-dhir commented on Jan 22, 2026

VishalGujela commented on Mar 19, 2026

aaryanm1208-ship-it commented on Nov 7, 2026

DHowett commented on Nov 8, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Inconsistent gutters/margins on HiDPI displays with `snapToGridOnResize` #4175