Some newlines appear to be broken #4107

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Jan 3, 2020
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jan 3, 2020
3. DHowett-MSFT commented on Jan 3, 2020

   

   Dustin L. Howett (MSFT) (DHowett-MSFT)

   on Jan 3, 2020

   ContributorAuthor

   More actions

   Looks like only WT...
4. zadjii-msft commented on Jan 4, 2020

   

   Mike Griese (zadjii-msft)

   on Jan 4, 2020

   Member

   More actions

   Is this a recent regression? I would have thought it might be #3271 but that hasn't merged yet.
5. Mike Griese (zadjii-msft)

   added

   Area-VTVirtual Terminal sequence supportVirtual Terminal sequence support

   Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   on Jan 4, 2020
6. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jan 4, 2020
7. DHowett-MSFT commented on Jan 4, 2020

   

   Dustin L. Howett (MSFT) (DHowett-MSFT)

   on Jan 4, 2020

   ContributorAuthor

   More actions

   Very. The current selfhost build from 12/31 does not exhibit this issue. Maybe related to the audit mode refactoring?
8. Dustin L. Howett (MSFT) (DHowett-MSFT)

   added

   Severity-BlockingWe won't ship a release like this! No-siree.We won't ship a release like this! No-siree.

   on Jan 5, 2020
9. j4james commented on Jan 5, 2020

   

   James Holderness (j4james)

   on Jan 5, 2020

   Collaborator

   More actions

   I believe the problem is in the TerminalDispatch::CursorPosition method here:
   

   terminal/src/cascadia/TerminalCore/TerminalDispatch.cpp

   Lines 40 to 44 in d711d73

   	RETURN_BOOL_IF_FALSE(FAILED(SizeTToShort(column, &x)) ||
   	FAILED(SizeTToShort(line, &y)));
   	RETURN_BOOL_IF_FALSE(FAILED(ShortSub(x, 1, &x)) ||
   	FAILED(ShortSub(y, 1, &y)));

   If the SizeTToShort calls succeed, then the FAILED tests are going to be false, and the RETURN_BOOL_IF_FALSE will force the method to abort.
10. DHowett-MSFT commented on Jan 5, 2020

    

    Dustin L. Howett (MSFT) (DHowett-MSFT)

    on Jan 5, 2020

    ContributorAuthor

    More actions

    Oof. Thanks.
11. Dustin L. Howett (MSFT) (DHowett-MSFT)

    added a commit that references this issue on Jan 5, 2020

    Fix flipped sense in TerminalDispatch::CursorPosition

    ...

    This issue will close once commit ddf0e18 is merged into the 'main' branch.

    ddf0e18
12. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Jan 5, 2020
13. Mike Griese (zadjii-msft)

    added this to the Terminal-2001 milestone on Jan 6, 2020
14. Dustin L. Howett (MSFT) (DHowett-MSFT)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Jan 6, 2020
15. Dustin L. Howett (MSFT) (DHowett-MSFT)

    closed this as completedin #4113on Jan 6, 2020
16. ghost added

    Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

    on Jan 6, 2020
17. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Jan 6, 2020
18. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Jan 6, 2020
19. Dustin L. Howett (MSFT) (DHowett-MSFT)

    added a commit that references this issue on Jan 6, 2020

    Fix flipped sense in TerminalDispatch::CursorPosition (#4113)

    ...

    This issue will close once commit 4882917 is merged into the 'main' branch.

    4882917