Skip to content

Further refine ToUnicodeEx calls in CharacterFromKeyEvent #3554

New issue
New issue
Closed
#4192
Closed
Further refine ToUnicodeEx calls in CharacterFromKeyEvent#3554
#4192
Labels
Area-InputRelated to input processing (key presses, mouse, etc.)Issue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Description

@miniksa
Michael Niksa (miniksa)
opened on Nov 13, 2019

To fix the latter tangential issue, I'd like to propose that we simply return the first character of the output buffer, if the return value of ToUnicodeEx is >1. What do you think? (I'd open a seperate PR for this.)

That sounds reasonable based on the analysis above.

Originally posted by Michael Niksa (@miniksa) in #3117 (comment)

This represents fixing the issue described in #3117 where other forms of multiple copies can occur based on the responses from ToUnicodeEx.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 13, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 13, 2019
  3. Michael Niksa (miniksa)
    added
    Area-InputRelated to input processing (key presses, mouse, etc.)
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Product-TerminalThe new Windows Terminal.
    on Nov 13, 2019
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 13, 2019

  5. miniksa commented on Nov 13, 2019

    @miniksa
    Michael Niksa (miniksa)
    on Nov 13, 2019
    ContributorAuthor

    Leonard Hecker (@lhecker), here's the follow on.

  6. Michael Niksa (miniksa)
    removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 13, 2019
  7. Mike Griese (zadjii-msft)
    added this to the Terminal Backlog milestone on Nov 13, 2019
  8. ghost added
    In-PRThis issue has a related PR
    on Apr 7, 2020
  9. ghost closed this as completedin #4192on Apr 7, 2020
  10. ghost added a commit that references this issue on Apr 7, 2020

    Delegate all character input to the character event handler (#4192)

    a9c9714
  11. ghost removed
    In-PRThis issue has a related PR
    on Apr 7, 2020
  12. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-InputRelated to input processing (key presses, mouse, etc.)Issue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions