Skip to content

Suspicious remains of previous window borders flash up when closing the window #3222

Closed

Description

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.5.2762.0

Steps to reproduce

Resize the window to smaller, then back to about its original size or even bigger.

Close the window.

Expected behavior

The window should simply disappear.

Actual behavior

For a fraction of a second, tons of horizontal and vertical lines, which look like the border of the window at its previous sizes, are painted inside the window area.

This suspiciously looks like some leftover widgets that don't get properly cleaned up during a resize, potentially consuming various resources (and maybe causing who knows what other problems).

(Could be related to #3207?)

WT-closing

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 16, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 16, 2019
  3. DHowett-MSFT commented on Oct 16, 2019

    @DHowett-MSFT
    Contributor

    So! This is actually because we're only painting the border of our window and leaving the rest unpainted. We've seen DWM do some very strange things when we paint the client area, so this is more reactionary than planned. 😄

  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 21, 2019
  5. DHowett-MSFT commented on Oct 21, 2019

    @DHowett-MSFT
    Contributor

    Sticking this one on to #1625. Thanks!

  6. ghost added
    In-PRThis issue has a related PR
    on Nov 2, 2019
  7. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 4, 2019
  8. added a commit that references this issue on Nov 4, 2019
    5dfc021
  9. ghost removed
    In-PRThis issue has a related PR
    on Nov 4, 2019
  10. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions