Skip to content

Window Border expands when showTabsInTitlebar is enabled #3136

Closed

Description

@RRitts

I originally opened #2333 which was supposed to be resolved by #2150 but I am still seeing the issue in 0.5

Environment

Windows build number: Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 0.5.2762.0


Steps to reproduce

Set showTabsInTitlebar to true.

Expected behavior

working

Actual behavior

true

When showTabsInTitlebar is false

false

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 9, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 9, 2019
  3. DHowett-MSFT commented on Oct 9, 2019

    @DHowett-MSFT
    Contributor

    Thanks for reopening! Now that the DPI thing is fixed, I've got a hunch.

    When you drag/drop things (anywhere!), does it seem like it takes longer to trigger or is less sensitive?

  4. RRitts commented on Oct 9, 2019

    @RRitts
    Author

    As a matter of fact, yes.

    We put a GPO in place years ago to cut down on things "missing" from our file server when a user would inadvertently drag and drop folders. It modifies the DragHeight and DragWidth values in HKLM\Control Panel\Desktop

  5. DHowett-MSFT commented on Oct 9, 2019

    @DHowett-MSFT
    Contributor

    YES! You are now an excellent case study on why nobody should use the SM_CXDRAG system metric to measure window borders.

  6. RRitts commented on Oct 10, 2019

    @RRitts
    Author

    Behold!

    BAM

    This is this DragHeight and DragWidth set to 4. The GPO was setting them to 45.

  7. added
    Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 10, 2019
  8. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 10, 2019
  9. zadjii-msft commented on Oct 25, 2019

    @zadjii-msft
    Member

    (We think that this is going to be closely related to a bucket of things, #3136 #1859 #3064 #1307)

  10. ghost added
    In-PRThis issue has a related PR
    on Nov 2, 2019
  11. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 4, 2019
  12. added a commit that references this issue on Nov 4, 2019
    5dfc021
  13. ghost removed
    In-PRThis issue has a related PR
    on Nov 4, 2019
  14. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions