Repository navigation
Implement Delta E 2000 to correct color perception #2638
Description
Environment
Windows build number: 10.0.18362.0
Windows Terminal version : 0.4.2382.0
ConEmu version: 180626
Steps to reproduce
- Copy the color palette for "<Solarized (John Doe)>" from ConEmu to terminal. Here's the relevant JSON:
{
"white" : "#fdf6e3",
"blue" : "#073642",
"green" : "#586e75",
"cyan" : "#657b83",
"red" : "#dc322f",
"purple" : "#6c71c4",
"yellow" : "#cb4b16",
"brightWhite" : "#eee8d5",
"brightBlack" : "#93a1a1",
"brightBlue" : "#268bd2",
"brightGreen" : "#859900",
"brightCyan" : "#2aa198",
"brightRed" : "#839496",
"brightPurple" : "#d33682",
"brightYellow" : "#b58900",
"black" : "#002B36",
"background" : "#002B36",
"foreground" : "#fdf6e3",
"name" : "Solarized (John Doe)"
}- Set powershell's color scheme to "Solarized (John Doe)"
- Run
[enum]::GetValues([System.ConsoleColor]) | Foreach-Object {Write-Host $_ -ForegroundColor $_}to admire the colors
Expected behavior
Colors look as nice as ConEmu's
Actual behavior
Most colors look nice and similar but "DarkBlue" looks completely different and way worse. See screenshot.
To get a somewhat similar color you need to set blue (DarkBlue) to something like "blue" : "#0B5669"
Reacted by Cristian Pop
Reacted by unageek and Adolfo Jayme-Barrientos
Activity
j4james commentedon Sep 2, 2019
It looks to me like it's cmder that might be getting the color wrong. I suggest you try out those color values in an HTML document with a little test like this:
As far as I can tell, that produces colors that exactly match what the Windows Terminal is showing.
DHowett-MSFT commentedon Sep 3, 2019
It looks like ConEmu does some cool stuff to make sure that a color can always be perceived. It bumps colors that could be invisible on a certain background up in perceptibility using the deltaE 2000 algorithm.
DHowett-MSFT commentedon Sep 3, 2019
It looks like ConEmu lets you configure that with its "Adjust lightness of indistinguishable text" option. I'm betting that if you turn it off, you'll see the same colors as in WT.
kojoru commentedon Sep 3, 2019
Dustin L. Howett (@DHowett) fair enough! Should I then open a new issue to feature request the same in terminal or can we convert this one?
WSLUser commentedon Sep 3, 2019
It would be pretty cool if we could do the same for Terminal. I had wondered why color output looked a bit different. Thanks for breaking it down Dustin L. Howett (@DHowett) .
[-]Unexpected color output compared to Cmder/ConEmu[/-][+]Implement Delta E 101 to correct color perception[/+]3 remaining items
DHowett commentedon May 22, 2020
All it would need is someone to do the work, and two people to review the pull request. 😄
I'd prefer to see a specification to answer a couple questions: would this happen during rendering? Color scheme loading? Is there somewhere we could, should cache colors? How do we hook this setting up into the layer it needs to go into? Should we nudge rgb or 256-color entries the same way as user-specified ones?
hectormz commentedon May 22, 2020
Three very easy things 😅
I can't answer any of the specifics regarding how this or WT actually work.
This would only pertain to foreground/background compatibility right?
But I would happy be with just user-specified colors.
Nudging 256 color entries would be nice if it wasn't much more overhead, and was cached ahead of time. But looking beyond the scope of user-specified colors might cause this fix to grow too much.
For example, opacity or background images would mess up these adjustments, so I don't think that should be supported/fixed.
CIPop commentedon Jun 10, 2020
+1 on this. To avoid others wasting their time:
Solarized Darkis not supported on Terminal today (assuming that most people like to see what they are typing).Dustin L. Howett (@DHowett) was kind enough to suggest workarounds in #6424 if you're hitting these issues.
[-]Implement Delta E 101 to correct color perception[/-][+]Implement Delta E 2000 to correct color perception[/+]kojoru commentedon Jun 12, 2020
Cristian Pop (@CIPop) I've been quite successfully using my patched version of
Solarized (John Doe)snatched from ConEmu ever since I filed this issue. It goes as follows:As compared to the built-in Solarized, it never produces any unreadable results and has decent difference between colors.
WSLUser commentedon Jun 12, 2020
Konstantin Yakushev (@kojoru) I suggest sending a PR updating the default with this instead.
kojoru commentedon Jun 12, 2020
Fair enough! Will do.
WSLUser commentedon Jun 12, 2020
This may help for anyone trying to implement this: http://www.easyrgb.com/en/math.php#text6. I got this website from the answer in https://stackoverflow.com/questions/5774152/calculate-how-humans-perceive-similarity-between-different-colours. We use chromium math functions in C++ so it just needs conversion to use that instead.
Change solarized to be more usable
Implement the Delta E algorithm to improve color perception (#11095)