Skip to content

Feature Request: disable bell #2360

Closed

Description

@ffes

Description of the new feature/enhancement

Make a setting to disable the bell. This could be a per profile setting.

Maybe other "bell" settings can be desirable like:

"bell": "enable"  (default)
"bell": "disable" (this feature request)
"bell": "visual"

So with that in mind don't let the setting be a boolean.

Probably related to #72

Activity

  1. added
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Aug 8, 2019
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 8, 2019
  3. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Aug 8, 2019
  4. added
    Area-SettingsIssues related to settings and customizability, for console or terminal
    Area-VTVirtual Terminal sequence support
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    and removed
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 8, 2019
  5. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Aug 8, 2019
  6. DHowett-MSFT commented on Aug 8, 2019

    @DHowett-MSFT
    Contributor

    This depends on #1608.

  7. trajano commented on Aug 9, 2019

    @trajano

    In addition, I want that to be configurable on both global and on profile level

    One change though, instead of the following to be default

    "bell": "enable" 
    

    use

    "bell": "default" 
    

    that way we can use

    "bell": "path to mp3,wav,ogg" 
    
  8. 9 remaining items

  9. zadjii-msft commented on Sep 29, 2020

    @zadjii-msft
    Member

    Frank Fesevur (@ffes) Absolutely, I'll make sure of that ☺️

    Note to self: we should do this as an enum like:

    "bellStyle": "audible"|"visible"|"none"
    

    We don't need to implement visible right now, but we should do it this way so we're future-proof

  10. ghost added
    In-PRThis issue has a related PR
    on Oct 1, 2020
  11. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 15, 2020
  12. ghost removed
    In-PRThis issue has a related PR
    on Oct 15, 2020
  13. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Oct 15, 2020
  14. added a commit that references this issue on Oct 15, 2020
    98806e2
  15. nathanblair commented on Nov 12, 2020

    @nathanblair

    I'm on the Windows Terminal Preview from the Microsoft Store, and while I can't determine if the bell is truly disabled for a Powershell shell, I am definitely hearing it while in Alpine WSL.

    Here's what I have in my settings.json (which I allowed Terminal to recreate after installing the newest 1.5 release):

        ...
        "bellStyle": "none",
        ...
    

    I'll note that VS Code was unable to see any "bell" properties (I assume these properties are populated from the json schema).

    I have other features from 1.5 like a maximizedFocus so I'm positive I have the most recent version. Should I do a full uninstall and then install Terminal Preview fresh?

  16. zadjii-msft commented on Nov 12, 2020

    @zadjii-msft
    Member

    Where did you put bellStyle? In the global settings (at the root of the json), or in a profile? Since bellStyle is a per-profile setting, if you want it to apply to all profiles, you'll need to put it in the profiles.defaults object:

    image

  17. nathanblair commented on Nov 12, 2020

    @nathanblair

    Excellent call! Indeed, that fixes it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-SettingsIssues related to settings and customizability, for console or terminalArea-VTVirtual Terminal sequence supportIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions