Skip to content

Resolve longstanding issues with conhost's MeasureRight #2089

Closed

Description

Environment

Windows build number: Version 10.0.18362.239
Windows Terminal version (if applicable):0.2.1831.0

Symfony 4.3

Steps to reproduce

Render a block with background color after the text. The used command is from Symfony 4.3. I can provide instructions or find the exact control codes that were used if needed.

Expected behavior

A solid block of background color. The screenshot is from cmd.

image

Actual behavior

The background color ends after the text.

image

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 25, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 25, 2019
  3. DHowett-MSFT commented on Jul 29, 2019

    @DHowett-MSFT
    Contributor

    Congrats, this is now the "Kill MeasureRight" (it'll make sense later) issue. The heart of the issue is that conhost can occasionally not tell whether the spaces that are in the buffer were on purpose or not. 🤷‍♀

  4. changed the title [-]Block with background color not rendered after text[/-] [+]Resolve longstanding issues with conhost's MeasureRight[/+] on Jul 29, 2019
  5. added
    Area-OutputRelated to output processing (inserting text into buffer, retrieving buffer text, etc.)
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    Product-ConhostFor issues in the Console codebase
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 29, 2019
  6. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 29, 2019
  7. BladeMF commented on Aug 6, 2019

    @BladeMF
    Author

    More examples (hopefuly useful):
    image
    See how "Success!" is OK, but "Application Migration" isn't? Not sure what that means.

  8. DHowett-MSFT commented on Feb 21, 2020

    @DHowett-MSFT
    Contributor

    I hacked at making MeasureRight care about attributes, and while it was slow it felt like it did the right thing.

  9. zadjii-msft commented on Dec 6, 2021

    @zadjii-msft
    Member

    Huh, this is /dup #32, and more broadly, we're tracking this in #8000.

  10. ghost closed this as completedon Dec 6, 2021
  11. ghost added
    Resolution-DuplicateThere's another issue on the tracker that's pretty much the same thing.
    on Dec 6, 2021
  12. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-OutputRelated to output processing (inserting text into buffer, retrieving buffer text, etc.)Issue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-ConhostFor issues in the Console codebaseResolution-DuplicateThere's another issue on the tracker that's pretty much the same thing.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions