Repository navigation
iTerm2 color schemes can not be parsed when using a non-english locale #2
Description
When trying to apply an iTerm2 color scheme on a computer with a German locale, the scheme can not be parsed (and applied).
Error message:
schemes\deuteranopia.itermcolors
Invalid Color
Invalid scheme - did not find 16 colors
Error loading ini file "./schemes\deuteranopia.itermcolors"
for key "DARK_BLACK"
the value "" is invalid
Could not find or load "schemes\deuteranopia.itermcolors"
Press any key to continue . . .
I tracked it down to Convert.ToDouble used in https://github.com/Microsoft/console/blob/1be2939f257bc89136bd6ea2ee04cdf75d12f3f0/tools/ColorTool/ColorTool/XmlSchemeParser.cs#L48 which will use the current locale to parse the value. Because we use a comma as decimal separator and the dot as group separator, the values are invalid.
I created a pull request (#1: Use invariant culture for parsing double values)
Reacted by Ruben Prins, Marco Wiedemeyer, jornh, Jonas B. Andersen and Russi
Activity
christian-korneck commentedon Aug 12, 2017
👍
khouzam commentedon Aug 14, 2017
This has been merged.
Merge pull request #2 from dgriffen/dev/dgriffen/minor-cleanup